Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP Abstract Class Codeintel #3807

Merged
merged 9 commits into from
Dec 11, 2019
Merged

Fix PHP Abstract Class Codeintel #3807

merged 9 commits into from
Dec 11, 2019

Conversation

ssigwart
Copy link
Contributor

@th3coop, I broke abstract classes with #3796. This fixes it.

Example Code

class A
{
	function test(){}
}

abstract class B extends A
{
	function __construct()
	{
		// Fixes completions here
		//$this->
	}
}

ssigwart and others added 9 commits July 22, 2019 18:55
```php
/** @var LogicException[] */
$arr1d = [new LogicException()];
$idx = 0;
//$arr1d[0]->
//$arr1d[$idx]->

/** @var LogicException[] */
$arr2d = [[new LogicException()]];
//$arr2d[0][0]->
```
Look Up Type Inference on PHP Parent
Handle Object Member Completion on Array Index
(integrated from the KomodoIDE master branch change f1a312082 by Nathan Rijksen <[email protected]>)

Komodo/KomodoIDE@f1a312082
@th3coop th3coop changed the base branch from master to 11.1.x December 11, 2019 18:00
@th3coop th3coop merged commit cc4a3e2 into Komodo:11.1.x Dec 11, 2019
@th3coop
Copy link
Member

th3coop commented Dec 11, 2019

Thanks @ssigwart .

@th3coop
Copy link
Member

th3coop commented Dec 11, 2019

hopefully i can get a nightly built and published today.

@th3coop
Copy link
Member

th3coop commented Dec 12, 2019

@ssigwart nightly will be public around noon. Auto-update should prompt you to install. FYI, I'll be holding off merging more PRs for a short time. Could you email me at [email protected] when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants