-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Github CI, DSL Builder, Seperate logging factory #251
Conversation
Looks interesting, thanks for this PR, I need a time to check on my fork and return with the results |
Hi @smallshen @zaleslaw, I would like to see Gradle wrapper validation in use. This small action validates, thats the checked in gradle-wrapper.jar was created by Gradle. It takes nearly no time and provides security. @smallshen I already created a PR in your fork. smallshen#1 |
Added gradle wrapper validation
@V3lop5 thanks, merged. |
@zaleslaw |
# Conflicts: # api/build.gradle # dataset/build.gradle # examples/build.gradle # gradle/wrapper/gradle-wrapper.properties # onnx/build.gradle # visualization/build.gradle
Also, performance issue oshai/kotlin-logging#34
In the Kotlin compiler, lambda is compiled into an object (without compiler flags). Plus the recent log4j RCE has made more people change logging frameworks, (for example, in my organization we are not allowed to use Apache related frameworks). |
Hi, @smallshen you did a really great job, but this migration will be postponed for a few months to clarify the situation on the market among our users who embed the KotlinDL functionality in their apps.
But I suggest keeping this PR (probably marked as draft or something else) to revisit the problem in the next two months. Now it contains a lot of mixed proposals (Gradle update (it's done), Github CI, DSL for building neural networks (we have a separate PR for that as I remember), and a proposal for a new logging module (which is postponed)) |
Log4j/logback is supported with Log4JFactory.setup(), and users don't need to change anything on their configs |
I agree with this |
Creating loggers is handled internally by the log4j API, so the logging behavior stays the same using Log4JFactory and does not require any changes. https://github.com/smallshen/KotlinDL/blob/master/logging/logging-log4j/src/main/kotlin/org/jetbrains/kotlinx/dl/logging/log4j/ Log4JFactory.kt and everything is handled by log4j's internal logger. https://github.com/smallshen/KotlinDL/blob/master/logging/logging-log4j/src/main/kotlin/org/jetbrains/kotlinx/dl/logging/log4j/ LoggerWrapper.kt#L30 |
# Conflicts: # api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/GraphTrainableModel.kt
No description provided.