install_deps: upgrade only specified packages, not full system #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `install_deps.sh` script behaviour to only upgrade specified packages instead of all installed packages. Full system upgrade is not necessary and can even be dangerous (see PR for more details)
to pass CI check
Howard20181
added a commit
that referenced
this pull request
Mar 3, 2024
Co-Authored-By: Howard Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
install_deps.shscript behaviour especially for Debian-based systems to only upgrade specified packages instead of all installed packages. (e.g.apt-get install -y ca-certificatesinstead ofapt-get upgrade -y ca-certificateswhereca-certificatesis ignored and a full system upgrade is launched)A full system upgrade is not necessary because the package manager handle dependencies/libraries upgrade automatically when you install/upgrade packages.
A full system upgrade can even be dangerous/unwanted on some cases, especially because of the
-yoption used here (e.g. a pending display driver update that could break everything with the next reboot).However, if ever in the future there is a real need for a complete system upgrade, the upgrade commands have been moved to a new
PM_SYSTEM_UPGRADE_MAParray (with its relatedSYSTEM_UPGRADE_OPTION), this time without the-yargument to let the user check and confirm the proposed updates.Checklist
-> Yes, on a Debian-based system (Ubuntu 23.10). Suse should not be impacted as the command is the same whether to update a package (
zypper up <package>) or all packages (zypper up)