feat: дз 7. hard. реализация пайпа filter #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letto228
reviewed
Nov 30, 2023
| @@ -37,7 +12,7 @@ | |||
| > | |||
| <div class="cards"> | |||
| <app-card | |||
| *ngFor="let product of productsGroup; trackBy: trackById" | |||
| transform<T extends IProduct, K extends keyof T>(value: T[], name: K, propValue: T[K]): T[] { | ||
| return value.filter((item: T) => { | ||
| if (Object.hasOwn(item, name)) { | ||
| if (typeof propValue === 'string') { |
There was a problem hiding this comment.
Рекомендовал бы это вычисление вынести за пределы цикла в константу, нам же нет необходимости в каждой итерации производить данное вычисление, его достаточно сделать один раз.
| export class FilterPipe implements PipeTransform { | ||
| transform<T extends IProduct, K extends keyof T>(value: T[], name: K, propValue: T[K]): T[] { | ||
| return value.filter((item: T) => { | ||
| if (Object.hasOwn(item, name)) { |
There was a problem hiding this comment.
А нужна ли тут проверка, типизация не спасает?
| return value.filter((item: T) => { | ||
| if (Object.hasOwn(item, name)) { | ||
| if (typeof propValue === 'string') { | ||
| const regExp = new RegExp(propValue); |
There was a problem hiding this comment.
Есть ли необходимость в отдельной регуляре? Почему бы не использовать includes?
И оптимально ли для каждого цикла создавать одну и ту же регулярку?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.