Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement logs #4169

Merged
merged 2 commits into from
Dec 19, 2024
Merged

chore: implement logs #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
989b6b5
chore: implement logs
vitormattos Dec 19, 2024
3ea292c
chore: add pcntl to solve psalm issue
vitormattos Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/psalm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ jobs:
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
with:
php-version: ${{ steps.versions.outputs.php-available }}
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, pdo_sqlite, posix, session, simplexml, sqlite, xmlreader, xmlwriter, zip, zlib
ini-values: disable_functions=""
coverage: none
ini-file: development
env:
Expand Down
3 changes: 3 additions & 0 deletions lib/Service/Install/ConfigureCheckService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use OCA\Libresign\Handler\JSignPdfHandler;
use OCA\Libresign\Helper\ConfigureCheckHelper;
use OCP\AppFramework\Services\IAppConfig;
use Psr\Log\LoggerInterface;

class ConfigureCheckService {
private string $architecture;
Expand All @@ -25,6 +26,7 @@ public function __construct(
private JSignPdfHandler $jSignPdfHandler,
private CertificateEngine $certificateEngine,
private SignSetupService $signSetupService,
private LoggerInterface $logger,
) {
$this->architecture = php_uname('m');
}
Expand Down Expand Up @@ -243,6 +245,7 @@ private function getErrorAndTipToResultOfVerify(array $result): array {
];
}
}
$this->logger->error('Invalid hash of binaries files', ['result' => $result]);
return [
'Invalid hash of binaries files.',
'Run occ libresign:install --all',
Expand Down
Loading