Add NeMo #7
Add NeMo #7
Conversation
configs/NVIDIA/nemo-release.yaml
Outdated
|
|
||
| testing: | ||
| dirs: | ||
| - tests |
There was a problem hiding this comment.
Do we want to run all their tests?
There was a problem hiding this comment.
Just an open question. I don't know how long their CI takes, but definitely like the idea.
|
@SeanNaren seems they also require several binaries to run the tests... |
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 85.09% 85.09%
=======================================
Files 2 2
Lines 208 208
=======================================
Hits 177 177
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| dirs: | ||
| - tests | ||
| # additional pytest arguments | ||
| pytest_args: -m "not pleasefixme and not torch_tts" --cpu --with_downloads --relax_numba_compat |
There was a problem hiding this comment.
Maybe @ericharper could explain the additional parameters here, was forwarded it from the slack channel!
There was a problem hiding this comment.
I am wondering what the commands shall do --cpu --with_downloads --relax_numba_compat
when I call pytest --help none of them is there... do you need dome special extension?
There was a problem hiding this comment.
@Borda I think you can define such things in a conftest.py file like here: https://github.com/NVIDIA/NeMo/blob/main/tests/conftest.py#L30
Borda
force-pushed
the
nemo
branch
2 times, most recently
from
398b4a5 to
a508e07
Compare
Borda
force-pushed
the
main
branch
4 times, most recently
from
a74814d to
cf5857a
Compare
|
@SeanNaren the env for GPU is now set correctly, mind checking the failing tests? |
|
I have fixed the lib install with docker but the tests are still failing... |
Before submitting
Starting with the release/CPU test
What does this PR do? [optional]
Resolves NVIDIA/NeMo#3502
Did you have fun?
Make sure you had fun coding 🙃