Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnboundLocalError when using the predict method with return_predictions=False. #20484

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

farhadrgh
Copy link
Contributor

@farhadrgh farhadrgh commented Dec 9, 2024

What does this PR do?

UnboundLocalError raises when using the predict method with return_predictions=False.

This is due to any_on_epoch not being defined if data_fetcher is an instance of _DataLoaderIterDataFetcher.

Fixes #20472

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20484.org.readthedocs.build/en/20484/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 9, 2024
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @farhadrgh !

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (601c060) to head (9546a22).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (601c060) and HEAD (9546a22). Click for more details.

HEAD has 182 uploads less than BASE
Flag BASE (601c060) HEAD (9546a22)
cpu 68 24
lightning 51 18
pytest 46 0
python3.9 18 6
lightning_fabric 13 0
python3.10 9 3
python3.11 18 6
python3.12 23 9
gpu 2 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20484     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23304    23248     -56     
=========================================
- Hits        20407    18291   -2116     
- Misses       2897     4957   +2060     

@lantiga lantiga merged commit 1e32ebf into Lightning-AI:master Dec 11, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnboundLocalError: local variable 'any_on_epoch' referenced before assignment in prediction loop
2 participants