Release 2.1.5 (#231)

* Update installation.md (#218) Added .com TLD to CDN URL * Fix typos in docs (#219) * Fix typos in docs * Fix typos * docs: Remove outdated line from poral-target docs I think this is something from the previous version * fix: Wormhole.close force=true and from=undefined * deps: remove cypress we don't have e2e tests right now. package takes up considerable size * example: programmatic example should use right build file. * build: 2.1.5 Co-authored-by: Mohd Shakir Zakaria <[email protected]> Co-authored-by: David Sanders <[email protected]> Co-authored-by: Mitar <[email protected]> Co-authored-by: Gohy Leandre <[email protected]>
LinusBorg · Jun 1, 2019 · 754c3a8 · 754c3a8
1 parent c49a452
commit 754c3a8
Show file tree

Hide file tree

Showing 17 changed files with 79 additions and 657 deletions.
diff --git a/dist/portal-vue.common.js b/dist/portal-vue.common.js
diff --git a/dist/portal-vue.esm.js b/dist/portal-vue.esm.js
diff --git a/dist/portal-vue.umd.js b/dist/portal-vue.umd.js
@@ -2,7 +2,7 @@
  /*! 
   * portal-vue © Thorsten Lünborg, 2019 
   * 
-  * Version: 2.1.4
+  * Version: 2.1.5
   * 
   * LICENCE: MIT 
   * 

diff --git a/dist/portal-vue.umd.min.js b/dist/portal-vue.umd.min.js
diff --git a/docs/api/portal-target.md b/docs/api/portal-target.md
@@ -286,8 +286,6 @@ Emitted everytime the component re-renders because the content from the `<Portal
 
 It receives two arguments, each is a `Boolean`, indicating the absense or presence of content for the target.
 
-The first argument is represents the current contents, the second one the previous contents (just like the arguments of a `watch` handler in a Vue component)
-
 <!-- prettier-ignore -->
 ```html {4}
 <template>

diff --git a/example/components/programmatic/index.vue b/example/components/programmatic/index.vue
@@ -29,11 +29,11 @@
 
 <script lang="ts">
 import Vue from 'vue'
-import { Wormhole } from 'portal-vue'
-// const { Wormhole } =
-//   process.env.NODE_ENV === 'production'
-//     ? require('@/../dist/portal-vue.common.js')
-//     : require('@/index').default
+
+const { Wormhole } =
+  process.env.NODE_ENV === 'production'
+    ? require('@/../dist/portal-vue.common.js')
+    : require('@/index').default
 
 export default Vue.extend({
   data() {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "portal-vue",
-  "version": "2.1.4",
+  "version": "2.1.5",
   "license": "MIT",
   "repository": "https://github.com/LinusBorg/portal-vue",
   "author": {
@@ -17,8 +17,7 @@
     "minify": "minify dist/portal-vue.umd.js --out-file dist/portal-vue.umd.min.js",
     "lint": "vue-cli-service lint",
     "test": "yarn test:unit",
-    "test:unit": "vue-cli-service test:unit",
-    "test:e2e": "vue-cli-service test:e2e"
+    "test:unit": "vue-cli-service test:unit"
   },
   "main": "dist/portal-vue.umd.js",
   "module": "dist/portal-vue.esm.js",
@@ -40,7 +39,6 @@
     "@linusborg/vue-ko-fi-button": "^0.1.0",
     "@types/jest": "^23.1.4",
     "@vue/cli-plugin-babel": "^3.1.0",
-    "@vue/cli-plugin-e2e-cypress": "^3.1.0",
     "@vue/cli-plugin-eslint": "^3.1.0",
     "@vue/cli-plugin-typescript": "^3.1.0",
     "@vue/cli-plugin-unit-jest": "^3.1.0",

diff --git a/src/components/wormhole.ts b/src/components/wormhole.ts
@@ -54,7 +54,7 @@ export const Wormhole = Vue.extend({
 
     close(transport: TransportVector, force = false) {
       const { to, from } = transport
-      if (!to || !from) return
+      if (!to || (!from && force === false)) return
       if (!this.transports[to]) {
         return
       }

diff --git a/src/types.ts b/src/types.ts
@@ -34,7 +34,7 @@ export interface Transport {
 
 export interface TransportVector {
   to: string
-  from: string
+  from?: string
 }
 
 export type PropWithComponent =

diff --git a/tests/e2e/.eslintrc b/tests/e2e/.eslintrc
diff --git a/tests/e2e/plugins/index.js b/tests/e2e/plugins/index.js
diff --git a/tests/e2e/specs/test.js b/tests/e2e/specs/test.js
diff --git a/tests/e2e/support/commands.js b/tests/e2e/support/commands.js
diff --git a/tests/e2e/support/index.js b/tests/e2e/support/index.js
diff --git a/tests/unit/specs/wormhole.spec.js b/tests/unit/specs/wormhole.spec.js
@@ -100,6 +100,44 @@ describe('Wormhole', function() {
     expect(wormhole.transports).toEqual({ target: [] })
   })
 
+  it('removes content on close() when force=true and from=undefined', () => {
+    wormhole.open({
+      from: 'test-portal',
+      to: 'target',
+      passengers: ['Test'],
+    })
+
+    wormhole.close(
+      {
+        to: 'target',
+      },
+      true
+    ) // force argument
+    expect(wormhole.transports).toEqual({ target: [] })
+  })
+
+  it('closes all transports to the same target when force=true and from=undefined', () => {
+    wormhole.open({
+      from: 'test-portal1',
+      to: 'target',
+      passengers: ['Test1'],
+    })
+
+    wormhole.open({
+      from: 'test-portal2',
+      to: 'target',
+      passengers: ['Test2'],
+    })
+
+    wormhole.close(
+      {
+        to: 'target',
+      },
+      true
+    ) // force argument
+    expect(wormhole.transports).toEqual({ target: [] })
+  })
+
   it('hasTarget()', function() {
     const check1 = wormhole.hasTarget('target')
     expect(check1).toBe(false)

diff --git a/types/lib/types.d.ts b/types/lib/types.d.ts
@@ -22,7 +22,7 @@ export interface Transport {
 }
 export interface TransportVector {
     to: string;
-    from: string;
+    from?: string;
 }
 export declare type PropWithComponent = VueConstructor<Vue> | ComponentOptions<Vue> | string;
 export declare type PortalProps = Partial<{