Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault-tolerant package installation with bash for loop #198

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mkrupczak3
Copy link

Scenario:
In the current version, if any singular package to be installed is missing or can't be found, the entire installation (including all other packages) will fail. This is because if apt-get is given a list of packages and one can't be installed, it assumes the entire command is invalid and shuts down.

Fix:
Instead of passing apt-get a list of packages to be installed, instead use a for loop to iterate over a list, installing each package by itself individually. This is much more robust, and if any individual install fails it has no effect on any other package installs. I've used this technique in my own install scripts to great success: https://github.com/mkrupczak3/gettools

Note:
Due to my IDE settings a bunch of whitespace has been mangled. My first change is on line 302, and any further changes are on any lines that have "opcion 2 == "0"" on them.

@LionSec Really like this tool, thanks!

@mkrupczak3
Copy link
Author

@LionSec Status?

@mkrupczak3
Copy link
Author

mkrupczak3 commented Jun 15, 2019

I don't think this repo is still being maintained.

I'll keep my modified fork here for the time being if anyone is interested:
https://github.com/mkrupczak3/Katoolin-Robust

@mkrupczak3
Copy link
Author

Discussion of this repo being dead:

#202 (comment)

I'd be willing to transfer ownership of my fork (Kalitoolin-Robust) if anyone's interested in trying to maintain a fork to keep this project going

@tassiolucas
Copy link

tassiolucas commented Nov 22, 2019

You are a beautiful @mkrupczak3 !!! I do not believe that a soul of God solved this problem of a script with such a good idea but so poorly executed and left that way, with so many stars on GitHub and stopped like that !!! It's a shame what the administrators of this repository did in abandoning it like this! They could at least pass the administration to you! Since it was you who solved the problem! My most sincere congratulations! And thanks for the help !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants