Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix(submission): prevent script injection #4460

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

ReenigneArcher
Copy link
Member

Description

Use env variable to prevent script injection. This should also solve the issue when a single quote was present in json data.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (b5f2afa) to head (a2c531b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4460   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files           1        1           
  Lines         345      345           
=======================================
  Hits          310      310           
  Misses         35       35           

@ReenigneArcher ReenigneArcher merged commit 2c9de92 into master Jun 6, 2024
14 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(submission)-prevent-script-injection branch June 6, 2024 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant