Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load files in workspace for --check (skip libraries) #2546

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

emmericp
Copy link
Contributor

@emmericp emmericp commented Feb 26, 2024

The current behavior of --check is to run diagnostics on all files that are loaded including defined libraries. I believe checking libraries is undesirable because:

  1. you might not own the code in there and any warning triggered in there can be non-actionable for you
  2. libraries can be very large and make check take a long time. For our project it adds about 2 minutes of time to check libraries and get warnings we can't do anything about anyways

Please let me know if you would prefer this behavior to be customizable instead, but I believe the current behavior is just undesirable in general.

@sumneko sumneko merged commit 85f7e6f into LuaLS:master Feb 27, 2024
2 of 10 checks passed
@sumneko
Copy link
Collaborator

sumneko commented Feb 27, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants