Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't do diagnostics when workspace is not ready #2692

Merged
merged 1 commit into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `FIX` Don't do diagnostics when the workspace is not ready
* `NEW` Reference workspace symbols in comments using `[some text](lua://symbolName)` syntax

## 3.9.0
Expand Down
3 changes: 3 additions & 0 deletions script/provider/diagnostic.lua
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,9 @@ local function isValid(uri)
if not config.get(uri, 'Lua.diagnostics.enable') then
return false
end
if not ws.isReady(uri) then
return false
end
if files.isLibrary(uri, true) then
local status = config.get(uri, 'Lua.diagnostics.libraryFiles')
if status == 'Disable' then
Expand Down
Loading