Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to build in Linux RISCV64. #2928

Closed
wants to merge 1 commit into from

Conversation

goyox86
Copy link

@goyox86 goyox86 commented Nov 2, 2024

Hi lua_ls team!

I recently manually built the server in my RISCV64 Ubuntu 24.10 Linux machine and so far it is working really well for me here.

It would be great that we would have riscv64 builds so things like mason.nvim work out of the box.

I just added some logic for the platform detection to work with riscv64 and changed the CH actions build script to install the cross compiler and toolchain for RISCV64, pretty much identical to the ARM64 steps.

Here is a small demo video:

Lua.Demo.webm

@goyox86 goyox86 force-pushed the goyox86/linux-riscv64 branch from dfd37a5 to 44f878a Compare November 2, 2024 14:34
@goyox86 goyox86 marked this pull request as ready for review November 2, 2024 15:43
@sumneko
Copy link
Collaborator

sumneko commented Nov 5, 2024

I'm not very inclined to accept compilation support from other platforms within this project, because based on experience, they usually follow this pattern:

  1. Accept a compilation PR from a platform.
  2. It works fine for a long time.
  3. One year later, when releasing a version, compilation failure is discovered.
  4. I can't resolve the compilation issue, and I can't reach the original contributor, or they don't have the time and energy to resolve it.
  5. To ensure a smooth release, the compilation for that platform is temporarily disabled, waiting for someone else to reactivate it.

I'm wondering if binary compilation and packaging should be separated into a standalone project?

@CppCXY
Copy link
Collaborator

CppCXY commented Nov 29, 2024

please consider use the rust port for release, see: https://github.com/LuaLS/lua-language-server-rust

@CppCXY CppCXY closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants