Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The eye does nothing if there are no hidden albums #2857

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 28, 2024

… to avoid confusing users

@ildyria ildyria requested a review from d7415 December 28, 2024 09:56
@ildyria
Copy link
Member Author

ildyria commented Dec 28, 2024

On request of @tinohager

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.08%. Comparing base (148ec74) to head (7476083).
Report is 16 commits behind head on master.

Additional details and impacted files

resources/js/components/gallery/AlbumHero.vue Outdated Show resolved Hide resolved
@ildyria ildyria changed the title The eye does nothing if there are no hidden albums, so better hide it… The eye does nothing if there are no hidden albums Jan 2, 2025
@ildyria ildyria merged commit 36546c2 into master Jan 2, 2025
52 checks passed
@ildyria ildyria deleted the improve-usability-of-eye branch January 2, 2025 17:43
@ildyria ildyria added this to the 6.3 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants