Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing include in hook-redirection.blade.php #2870

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

kiancross
Copy link
Contributor

In commit b560ff5, the layouts.app base template was added to hook-redirection.blade.php. However, in commit b156ec4, the base template was removed, leaving a broken include reference.

This causes commands like php artisan view:cache to fail due to the missing template.

This commit removes the invalid include, restoring the file to its state prior to b560ff5 and resolving the issue.

In commit b560ff5, the `layouts.app` base template was added to
`hook-redirection.blade.php`. However, in commit b156ec4, the base
template was removed, leaving a broken include reference.

This causes commands like `php artisan view:cache` to fail due to
the missing template.

This commit removes the invalid include, restoring the file to its
state prior to b560ff5 and resolving the issue.
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (2b74431) to head (3178b87).
Report is 8 commits behind head on master.

Additional details and impacted files

@ildyria
Copy link
Member

ildyria commented Jan 2, 2025

Good spot, that's a left over from the Livewire part...

@ildyria ildyria merged commit 98305ff into LycheeOrg:master Jan 2, 2025
32 checks passed
@kiancross kiancross deleted the fix-missing-include branch January 2, 2025 17:29
@ildyria ildyria added this to the 6.3 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants