Fix saving password without hashing it

MBaysanLab · Nov 22, 2023 · 63785b5 · 63785b5
1 parent ff54cd5
commit 63785b5
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 18 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -3,23 +3,20 @@ on:
     branches:
       - dev
   workflow_dispatch:
-
+  
 jobs:
   run_pull:
     name: run pull
     runs-on: ubuntu-latest
-
+    
     steps:
-      - name: install ssh keys
-        # check this thread to understand why its needed:
-        # https://stackoverflow.com/a/70447517
-        run: |
-          install -m 600 -D /dev/null ~/.ssh/id_rsa
-          echo "${{ secrets.SSH_PRIVATE_KEY }}" > ~/.ssh/id_rsa
-          ssh-keyscan -H ${{ secrets.SSH_HOST }} > ~/.ssh/known_hosts
-      - name: connect and pull
-        run: | 
-          ssh ${{ secrets.SSH_USER }}@${{ secrets.SSH_HOST }}
-          "cd ${{ secrets.WORK_DIR }} && git checkout ${{ secrets.MAIN_BRANCH }} && \
-          git pull && docker compose up -d --build && \
-          docker compose exec web bash -l -c "python manage.py makemigrations && python manage.py migrate""
+    - name: install ssh keys
+      # check this thread to understand why its needed:
+      # https://stackoverflow.com/a/70447517
+      run: |
+        install -m 600 -D /dev/null ~/.ssh/id_rsa
+        echo "${{ secrets.SSH_PRIVATE_KEY }}" > ~/.ssh/id_rsa
+        ssh-keyscan -H ${{ secrets.SSH_HOST }} > ~/.ssh/known_hosts
+    - name: connect and pull
+      run: ssh ${{ secrets.SSH_USER }}@${{ secrets.SSH_HOST }} "cd ${{ secrets.WORK_DIR }} && git checkout ${{ secrets.MAIN_BRANCH }} && git pull && exit"
+
diff --git a/cosapweb/api/serializers.py b/cosapweb/api/serializers.py
@@ -68,8 +68,9 @@ def create(self, data):
             first_name=data["first_name"],
             last_name=data["last_name"],
             email=data["email"],
-            password=data["password"],
         )
+        user.set_password(data["password"])
+        user.save()
 
         return user
 

diff --git a/cosapweb/settings.py b/cosapweb/settings.py
@@ -157,8 +157,8 @@
 
 MEDIA_ROOT = os.environ.get("COSAP_API_DATA", os.path.join(BASE_DIR, "data"))
 
-DJANGO_DRF_FILEPOND_UPLOAD_TMP = os.path.join(MEDIA_ROOT, "filepond_temp_files")
-DJANGO_DRF_FILEPOND_FILE_STORE_PATH = MEDIA_ROOT
+DJANGO_DRF_FILEPOND_UPLOAD_TMP = os.path.join(BASE_DIR, "filepond_temp_files")
+DJANGO_DRF_FILEPOND_FILE_STORE_PATH = BASE_DIR
 
 # Static files (CSS, JavaScript, Images)
 # https://docs.djangoproject.com/en/4.0/howto/static-files/