Directly specify fftlength in config (#318)

* add fftlength explicitly in config * use empty value for fftlength * add comment * move fftlength in review config under data conditioning
ML4GW · Nov 21, 2024 · 3842499 · 3842499
1 parent 60fd134
commit 3842499
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 0 deletions.
diff --git a/aframe/pipelines/sandbox/configs/base.cfg b/aframe/pipelines/sandbox/configs/base.cfg
@@ -35,6 +35,9 @@ batch_size = 512
 prior = priors.priors.end_o3_ratesandpops
 
 # data conditioning / preprocessing parameters
+
+# keep empty to use the default
+fftlength = 
 sample_rate = 2048
 fduration = 1
 highpass = 32
@@ -126,6 +129,7 @@ request_disk = 200MB
 request_cpus = 1
 
 [luigi_ExportLocal]
+fftlength = &::luigi_base::fftlength
 fduration = &::luigi_base::fduration
 kernel_length = &::luigi_base::kernel_length
 inference_sampling_rate = &::luigi_base::inference_sampling_rate

diff --git a/aframe/pipelines/sandbox/configs/bbh.cfg b/aframe/pipelines/sandbox/configs/bbh.cfg
@@ -21,6 +21,7 @@ buffer = 16
 
 [luigi_Train]
 ifos = &::luigi_base::ifos
+fftlength = &::luigi_base::fftlength
 kernel_length = &::luigi_base::kernel_length
 sample_rate = &::luigi_base::sample_rate
 highpass = &::luigi_base::highpass

diff --git a/aframe/pipelines/sandbox/configs/bns.cfg b/aframe/pipelines/sandbox/configs/bns.cfg
@@ -30,6 +30,7 @@ buffer = 90
 
 [luigi_Train]
 ifos = &::luigi_base::ifos
+fftlength = &::luigi_base::fftlength
 kernel_length = &::luigi_base::kernel_length
 sample_rate = &::luigi_base::sample_rate
 highpass = &::luigi_base::highpass

diff --git a/aframe/pipelines/sandbox/configs/review.cfg b/aframe/pipelines/sandbox/configs/review.cfg
@@ -35,6 +35,9 @@ batch_size = 512
 prior = priors.priors.end_o3_ratesandpops
 
 # data conditioning / preprocessing parameters
+
+# keep empty to use the default
+fftlength = 
 sample_rate = 2048
 fduration = 1
 highpass = 32
@@ -82,6 +85,7 @@ request_disk = 200MB
 request_cpus = 1
 
 [luigi_ExportLocal]
+fftlength = &::luigi_base::fftlength
 fduration = &::luigi_base::fduration
 kernel_length = &::luigi_base::kernel_length
 inference_sampling_rate = &::luigi_base::inference_sampling_rate

diff --git a/aframe/pipelines/sandbox/configs/tune.cfg b/aframe/pipelines/sandbox/configs/tune.cfg
@@ -12,6 +12,7 @@ inherit = $AFRAME_REPO/aframe/pipelines/sandbox/configs/base.cfg
 [luigi_TuneTask]
 config = $AFRAME_REPO/projects/train/config.yaml
 tune_config = $AFRAME_REPO/projects/train/configs/tune.yaml
+fftlength = &::luigi_base::fftlength
 ifos = &::luigi_base::ifos
 kernel_length = &::luigi_base::kernel_length
 sample_rate = &::luigi_base::sample_rate