Add SNR check to foreground when plotting and fix paths #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - can we also add a logging statement with the amount of injections that were bad? |
|
Yeah, good idea |
EthanMarx
reviewed
Nov 19, 2024
| foreground = foreground[foreground.snr < 1e4] | ||
| mask = foreground.snr > 1e4 | ||
| num_unphysical = sum(mask) | ||
| if num_unphysical > 0: |
There was a problem hiding this comment.
sorry for nit pick, but I dont think we even need the if statement here right?
There was a problem hiding this comment.
I felt like this was the kind of logging statement that could cause confusion if it reported 0 waveforms removed
EthanMarx
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.