Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes (Splitting into smaller PRs (done)) #214

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

labbo-lab
Copy link
Contributor

@labbo-lab labbo-lab commented Jun 12, 2022

Splitting into smaller PRs

List of changes


It's finished!

First commit: Jun 12, 2022, 12:42 PM CDT
Last commit: Sep 29, 2022, 2:22 PM CDT
Number of commits: 20
Files changed: 11
Additions: +45
Deletions: -34

Minor change for part of an info overhaul
@labbo-lab labbo-lab marked this pull request as draft June 12, 2022 17:42
@labbo-lab labbo-lab changed the title Update info.js (minor) Random improvements Jun 12, 2022
@labbo-lab
Copy link
Contributor Author

labbo-lab commented Jun 12, 2022

Improved:
X button now has hover text
Being rate limited now actually tells the user that they're being rate limited
Fixed up info, edited some element descriptions, added a short description for empty, punctuation
Beta hashtag in browse now clickable

Other minor improvements

@labbo-lab labbo-lab marked this pull request as ready for review June 12, 2022 19:05
@labbo-lab labbo-lab changed the title Random improvements Quality improvements Jun 12, 2022
@labbo-lab labbo-lab changed the title Quality improvements Quality of life improvements Jun 12, 2022
@labbo-lab labbo-lab changed the title Quality of life improvements Random improvements Jun 12, 2022
Final commit for this pull!
Hope you like it
@labbo-lab labbo-lab marked this pull request as draft June 13, 2022 19:00
@labbo-lab labbo-lab marked this pull request as ready for review June 13, 2022 19:00
@labbo-lab labbo-lab marked this pull request as draft September 6, 2022 00:44
@labbo-lab
Copy link
Contributor Author

added clarifications and cleared some things up

@labbo-lab labbo-lab marked this pull request as ready for review September 6, 2022 00:44
@labbo-lab labbo-lab changed the title Random improvements Minor overhaul Sep 6, 2022
@labbo-lab labbo-lab changed the title Minor overhaul Minor changes Sep 6, 2022
@MaxBittker
Copy link
Owner

these seem like great changes! I'll test them out this week :)

@labbo-lab
Copy link
Contributor Author

Fixed something that was bothering me:
Without the fix:
image

With the fix:
image

@MaxBittker
Copy link
Owner

oo good one

@labbo-lab
Copy link
Contributor Author

Added sink crashing fix from #222
(By removing the call for update_sink)

@labbo-lab
Copy link
Contributor Author

Added sink crashing fix from #222 (By removing the call for update_sink)

I think that's going to be the last commit for this pull request 😅

@labbo-lab labbo-lab mentioned this pull request Sep 29, 2022
@labbo-lab labbo-lab changed the title Minor changes Minor changes (Finished!) Sep 30, 2022
@labbo-lab
Copy link
Contributor Author

(finished for real this time, I seriously need to stop lol)

@labbo-lab labbo-lab closed this Sep 30, 2022
@labbo-lab labbo-lab deleted the patch-4 branch September 30, 2022 17:44
@labbo-lab labbo-lab restored the patch-4 branch September 30, 2022 17:44
@labbo-lab labbo-lab reopened this Sep 30, 2022
@labbo-lab
Copy link
Contributor Author

(fixed conflict)

labbo-lab added a commit to labbo-lab/sandfix that referenced this pull request Oct 19, 2022
@labbo-lab labbo-lab mentioned this pull request Oct 19, 2022
@labbo-lab labbo-lab changed the title Minor changes (Finished!) Minor changes (Splitting into smaller PRs) Oct 19, 2022
@labbo-lab labbo-lab changed the title Minor changes (Splitting into smaller PRs) Minor changes (Splitting into smaller PRs (done)) Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants