Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core.cpp #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Core.cpp #50

wants to merge 1 commit into from

Conversation

echolevel
Copy link

I needed iXML output to stdout as well as an .xml file, so I added a cout just before the file is saved. There may be a more elegant way to do it, in which case I'd be glad to hear about it!

Not sure why there's no option to output iXML to stdout as well as a .xml file, so I've crudely added it for my own purposes.
@JeromeMartinez
Copy link
Member

This is too direct, and specific:

  • I would prefer that this is usable if an option is set
  • providing it only for iXML makes the interface non consistent, should be done for all options.

IMO there is the need of some refactoring for having a common function for writing to files then an option should be used for knowing if we need to save in a file or export to cout or both.

I get it that this is a lot more code to change...

@echolevel
Copy link
Author

Agreed, making it consistent and optional would be best - but unfortunately beyond my own expertise. Perhaps someone else will come along and take a look in the future, or I'll return to it when my C++ skills improve :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants