-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo #24930
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -354,6 +354,7 @@ jobs: | |||
executor: node-browsers-small | |||
steps: | |||
- run: *shallow-git-clone | |||
- run: sudo corepack enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it with with just corepack enable
sans sudo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, this is what happens without sudo https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/84179/workflows/a00c10d8-5c25-4604-9332-5a71d51e512f/jobs/3025527
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24930 +/- ##
========================================
Coverage 65.79% 65.79%
========================================
Files 1364 1364
Lines 54315 54315
Branches 14126 14126
========================================
Hits 35732 35732
Misses 18583 18583 ☔ View full report in Codecov by Sentry. |
Builds ready [e8bc321]
Page Load Metrics (660 ± 484 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Builds ready [176984d]
Page Load Metrics (107 ± 123 ms)
|
Builds ready [39fd66a]
Page Load Metrics (232 ± 256 ms)
|
@HowardBraham This broke some GitHub Actions workflows.. |
Description
yarn-*.cjs
files from our repo (see this discussion about how these 2.6MB files shouldn't be committed)corepack enable
in CircleCIThis is very similar to MetaMask/metamask-module-template#243
Related issues
Similar: MetaMask/metamask-module-template#243
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist