You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically set new PRs targeting main to "draft" state.
Enforce the E2E Bitrise Status Check on lifecycle on incoming PRs which will essentially enforce that the PR has 1 of the two labels 'Run Smoke E2E' or 'No E2E Smoke Needed'
With this change we're looking to improve the posture on our PR lifecycle with auto drafts and enforce a higher standard for incoming changes towards or E2E testing posture.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA NeededApply this label when your PR does not need any QA effort.release-7.38.0Issue or pull request that will be included in release 7.38.0Run Smoke E2ETriggers smoke e2e on Bitriseteam-dev-opsDevOps team
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jake-perkins
added
No QA Needed
metamaskbot
added
the
release-7.38.0
Description
This PR does a few things
With this change we're looking to improve the posture on our PR lifecycle with auto drafts and enforce a higher standard for incoming changes towards or E2E testing posture.
Related issues
[Fixes:]
#11747
Manual testing steps
UC1 : Nether E2E Label is set
-> https://github.com/MetaMask/metamask-mobile/actions/runs/11826040868/job/32951145968?pr=12243
Expected : Not Mergeable
UC2 : docs PR
Should run: false, Reason: The pull request is documentation related.
Skipping Bitrise status check. due to the following reason: The pull request is documentation related.
Created 'Bitrise E2E Status' check with skipped status for commit dea08a9
https://github.com/MetaMask/metamask-mobile/actions/runs/11826187817/job/32951608300?pr=12243
Expected: Mergeable
UC3 : No E2E Smoke Needed Label is set
Anti label: true
Should run: false, Reason: The pull request has the anti-label.
Skipping Bitrise status check. due to the following reason: The pull request has the anti-label.
Created 'Bitrise E2E Status' check with skipped status for commit dea08a9[22]
https://github.com/MetaMask/metamask-mobile/actions/runs/11826234735/job/32951749305?pr=12243
Expected Mergeable
UC4: Smoke E2E Label is set
Should run: true, Reason: The smoke test label is present.
Starting Bitrise build for commit dea08a9
Screenshots/Recordings
Before
N/A CICD Changes only
After
N/A CICD Changes only
Pre-merge author checklist
Pre-merge reviewer checklist