-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement send max to send flow #12754
base: main
Are you sure you want to change the base?
feat: Implement send max to send flow #12754
Conversation
…s-not-adjusted-in-response-to-changes-in-the-gas-fee
Bitrise❌❌❌ Commit hash: 39d4b19 Note
Tip
|
Bitrise✅✅✅ Commit hash: f33da7b Note
|
Quality Gate passedIssues Measures |
@@ -604,14 +629,33 @@ class Confirm extends PureComponent { | |||
? AppConstants.GAS_OPTIONS.MEDIUM | |||
: this.state.gasSelected; | |||
|
|||
if ( | |||
maxValueMode && | |||
selectedAsset.isETH && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is always set to true
regardless of the network using ETH or not, so a flag if the selected asset is native token
Description
This PR implements "Use Max" feature to the send flow.
In the
Amount
step we setmaxValueMode
astrue
. When user gets in to theConfirm
step, depending on the value, transaction value is getting updated.Related issues
#8516
Manual testing steps
Amount
screenScreenshots/Recordings
send.flow.max.eth.mp4
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist