Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands for managing built-in font packages #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Yixian15
Copy link

@Yixian15 Yixian15 commented Aug 6, 2024

Add commands for managing built-in font packages.

Copy link
Contributor

Learn Build status updates of commit f4dae6b:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOBuiltInFontPackageSettings.md ❌Error Details
sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md ⚠️Warning Details
sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Add-SPOGeoAdministrator.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Add-SPOUser.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Export-SPOUserInfo.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOBuiltInSiteTemplateSettings.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOContainerTypeConfiguration.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPODeletedContainer.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPODeletedSite.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOExternalUser.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOGeoAdministrator.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOGeoStorageQuota.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOHideDefaultThemes.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOListFileVersionBatchDeleteJobProgress.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOListFileVersionExpirationReportJobProgress.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/Get-SPOListVersionPolicy.yml ⚠️Warning Details
sharepoint/sharepoint-ps/sharepoint-online/index.yml ⚠️Warning Details

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOBuiltInFontPackageSettings.md

  • Line 0, Column 0: [Error: MAML2Yaml_LoadFileFailed]
Failed to load file: C:/LocalRun/W/i5i2-s/sharepoint/sharepoint-ps/sharepoint-online/Get-SPOBuiltInFontPackageSettings.md:14:(63) '

## EXAMPLE

'
 Unexpected header name EXAMPLE, please try to use PlatyPS validate the content

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'SharePoint Server Cmdlets' is duplicated in: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(2,8), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(2,8)'. Titles must be unique within a docset.
  • Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SharePoint Server Cmdlets' is duplicated with other articles: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(6,1), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(6,1)'. First level headings must be unique within a docset.
  • Line 8, Column 53: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer'.
  • Line 31, Column 62: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer.Add-SPShellAdmin'.
  • Line 2, Column 1: [Suggestion: manager-missing - See documentation] Missing required attribute: 'manager'. Add a valid Microsoft alias for the author's manager.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

sharepoint/docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md

  • Line 2, Column 8: [Warning: duplicate-titles - See documentation] Title 'SharePoint Server Cmdlets' is duplicated in: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(2,8), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(2,8)'. Titles must be unique within a docset.
  • Line 6, Column 1: [Warning: duplicate-h1s - See documentation] H1 'SharePoint Server Cmdlets' is duplicated with other articles: 'docs-conceptual/sharepoint-server/sharepoint-server-cmdlets.md(6,1), docs-conceptual/sharepoint-server/sharepoint-server-sub-cmdlets.md(6,1)'. First level headings must be unique within a docset.
  • Line 8, Column 53: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer'.
  • Line 31, Column 62: [Warning: xref-not-found - See documentation] Cross reference not found: 'SharePointServer.Add-SPShellAdmin'.
  • Line 2, Column 1: [Suggestion: manager-missing - See documentation] Missing required attribute: 'manager'. Add a valid Microsoft alias for the author's manager.
  • Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

sharepoint/sharepoint-ps/sharepoint-online/Add-SPOGeoAdministrator.yml

  • Line 14, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Remove-SPOGeoAdministrator.yml'.

sharepoint/sharepoint-ps/sharepoint-online/Add-SPOUser.yml

  • Line 10, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'New-SPOSiteGroup.yml'.
  • Line 12, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Get-SPOUser.yml'.
  • Line 14, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Set-SPOUser.yml'.
  • Line 16, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Remove-SPOUser.yml'.

sharepoint/sharepoint-ps/sharepoint-online/Export-SPOUserInfo.yml

  • Line 10, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'New-SPOSiteGroup.yml'.
  • Line 12, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Get-SPOUser.yml'.
  • Line 14, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Set-SPOUser.yml'.
  • Line 16, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Remove-SPOUser.yml'.

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOBuiltInSiteTemplateSettings.yml

  • Line 7, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Set-SPOBuiltInSiteTemplateSettings.yml'.

sharepoint/sharepoint-ps/sharepoint-online/Get-SPOContainerTypeConfiguration.yml

  • Line 7, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Set-SPOContainerTypeConfiguration.yml'.

sharepoint/sharepoint-ps/sharepoint-online/Get-SPODeletedContainer.yml

  • Line 12, Column 9: [Warning: file-not-found - See documentation] Invalid file link: 'Remove-SPOContainer.yml'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:


## SYNOPSIS

Gets settings of built-in font packages.
Copy link
Contributor

@samkabue samkabue Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this could be improved a little bit, e.g., to add a bit more info? I'd suggest you work with your PM on this PR.

Also, please take a look at other cmdlet documentations to see if there's anything you'd need to add

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(applies to the other file too)


Use this cmdlet to get all settings of built-in font packages.

## EXAMPLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be
level 2 header: EXAMPLES
level 3 header: EXAMPLE

## EXAMPLES
### EXAMPLE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(applies to the other file too)

```

## PARAMETERS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove as you don't have params


### -HideBuiltInFontPackages

Hide built in font packages from SharePoint sites if this value is true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide built

please work with your PM on this documentation. e.g., from reading this, it's not clear what "hiding" means/what effect it has etc

Copy link
Contributor

@samkabue samkabue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@samkabue samkabue added the Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back to submitter The pull request didn't pass the review criteria and has been returned to the writer for updates Microsoft submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants