fix: checkpoint conversion to HF #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajude2s
reviewed
Dec 19, 2024
| @@ -115,7 +116,7 @@ def forward( | |||
| raise NotImplementedError | |||
| model_input = {"input_ids": input_ids, "attention_mask": attention_mask} | |||
| model_forward_output: dict[str, torch.Tensor] = self.model.forward(model_input) | |||
| if return_dict: | |||
| if not return_dict: | |||
There was a problem hiding this comment.
I executed the checkpoint conversion. Everything works perfectly.
I ran eval harness with these changes (since the HFModelAdapterConfig and HFModelAdapter are required while evaluating modalities using eval harness as well). This change seems to have affected the eval run. On reverting this change back, it seems to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is an attempt to fix #284. The checkpoint conversion runs through successfully with the changes. However, it should be double-checked that everything is correct, further adjustments might be necessary.
General Changes
Breaking Changes
Checklist before submitting final PR
python tests/tests.py)CHANGELOG_DEV.md)