fix(val): Remove eslint validator, update dependencies, bug fixes #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mammerla
commented
Dec 16, 2024
mammerla
commented
- Refactor most info generators to use enums for titles
- Fix some blockbench import issues with 1.8 geometries
- Init audio files on import
- Rename add-on validators to "cooperative add-on validators"
- Refactor most info generators to use enums for titles - Fix some blockbench import issues with 1.8 geometries - Init audio files on import - Rename add-on validators to "cooperative add-on validators"
ihfdayton
approved these changes
Dec 17, 2024
app/src/info/PackInfoGenerator.ts
Outdated
| info.defaultIcon = infoSet.getFirstStringValue("PACK", 21); | ||
| info.defaultBehaviorPackUuid = infoSet.getFirstStringValue(this.id, PackInfoGeneratorTest.behaviorPackUuid); | ||
|
|
||
| info.defaultIcon = infoSet.getFirstStringValue(this.id, 21); |
There was a problem hiding this comment.
info.defaultIcon = infoSet.getFirstStringValue(this.id, PackInfoGeneratorTest.resourcePackIcon)instead?
app/src/info/PackInfoGenerator.ts
Outdated
Comment on lines
55
to
60
| info.defaultIcon = infoSet.getFirstStringValue(this.id, 22); | ||
| } | ||
|
|
||
| // because it's heavy, remove pack icon from this list of issues. Though the summarize op is probably | ||
| // the wrong place to do this. | ||
| infoSet.removeItems("PACK", [21, 22]); | ||
|
|
||
| info.defaultBehaviorPackMinEngineVersion = infoSet.getFirstNumberArrayValue("PACK", 1); | ||
| info.defaultBehaviorPackName = infoSet.getFirstNumberArrayValue("PACK", 4); | ||
| info.defaultBehaviorPackDescription = infoSet.getFirstNumberArrayValue("PACK", 5); | ||
| info.defaultResourcePackUuid = infoSet.getFirstStringValue("PACK", 12); | ||
| info.defaultResourcePackMinEngineVersion = infoSet.getFirstNumberArrayValue("PACK", 11); | ||
| info.defaultResourcePackName = infoSet.getFirstNumberArrayValue("PACK", 14); | ||
| info.defaultResourcePackDescription = infoSet.getFirstNumberArrayValue("PACK", 15); | ||
|
|
||
| info.subpackCount = infoSet.getFirstNumberValue("PACK", 18); | ||
|
|
||
| info.subpackTier1Count = infoSet.getCount("PACK", 41); | ||
| info.subpackTier2Count = infoSet.getCount("PACK", 42); | ||
| info.subpackTier3Count = infoSet.getCount("PACK", 43); | ||
| info.subpackTier4Count = infoSet.getCount("PACK", 44); | ||
| infoSet.removeItems(this.id, [21, 22]); |
app/src/info/PackInfoGenerator.ts
Outdated
| PackInfoGeneratorTest.resourcePackDescription | ||
| ); | ||
|
|
||
| info.subpackCount = infoSet.getFirstNumberValue(this.id, 18); |
app/src/info/PackInfoGenerator.ts
Outdated
Comment on lines
84
to
87
| info.subpackTier1Count = infoSet.getCount(this.id, 41); | ||
| info.subpackTier2Count = infoSet.getCount(this.id, 42); | ||
| info.subpackTier3Count = infoSet.getCount(this.id, 43); | ||
| info.subpackTier4Count = infoSet.getCount(this.id, 44); |
There was a problem hiding this comment.
Any particular reason 41-44 are absent from the enumeration?
| info.subchunkLessChunkCount = infoSet.getSummedNumberValue("WORLDDATA", 107); | ||
| info.subchunkLessChunkCount = infoSet.getSummedNumberValue( | ||
| "WORLDDATA", | ||
| WorldDataInfoGeneratorTest.subchunklessChunks |
There was a problem hiding this comment.
WorldDataInfoGeneratorTest.subchunklessChunks == 7, whereas before we used 107. Missing value in the enum?
There was a problem hiding this comment.
Yeah, I think this was an error originally in the code (in one place it was 7 and in another it was 107) that converting to enums helped me to catch
| new ProjectInfoItem( | ||
| InfoItemType.info, | ||
| this.id, | ||
| WorldDataInfoGeneratorTest.chunks, |
There was a problem hiding this comment.
WorldDataInfoGeneratorTest.chunks == 1 whereas before we passed 101. Intentional?
| ); | ||
| items.push( | ||
| new ProjectInfoItem( | ||
| InfoItemType.info, | ||
| this.id, | ||
| 107, | ||
| WorldDataInfoGeneratorTest.subchunklessChunks, |
| items.push( | ||
| new ProjectInfoItem( | ||
| InfoItemType.testCompleteFail, | ||
| this.id, | ||
| 140, | ||
| CooperativeAddOnItemRequirementsGeneratorTest.ResourcePackDoesNotHavePackScopeWorld, |
There was a problem hiding this comment.
170 now instead of 140. Intentional?
There was a problem hiding this comment.
This might have been another case where I had duplicate identifers for two different errors that is now straightened out :)
| items.push( | ||
| new ProjectInfoItem( | ||
| InfoItemType.testCompleteFail, | ||
| this.id, | ||
| 111, | ||
| CooperativeAddOnItemRequirementsGeneratorTest.BehaviorAnimationControllerNameNotInExpectedForm, |
There was a problem hiding this comment.
I believe this should be BehaviorAnimationNameNotInExpectedForm not BehaviorAnimationControllerNameNotInExpectedForm
|
🎉 This issue has been resolved in version 0.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.