refactor: address IntelliJ QAPlug plugin findings

engine/src/main/java/org/terasology/engine/logic/behavior/BehaviorSystem.java

@@ -37,10 +37,10 @@
 
 /**
  * Behavior tree system
- * <p/>
+ * <p>
  * Each entity with BehaviorComponent is kept under control by this system. For each such entity a behavior tree is
  * loaded and an interpreter is started.
- * <p/>
+ * <p>
  * Modifications made to a behavior tree will reflect to all entities using this tree.
  */
 @RegisterSystem(RegisterMode.AUTHORITY)

engine/src/main/java/org/terasology/engine/logic/behavior/CollectiveBehaviorSystem.java

@@ -41,10 +41,10 @@
 
 /**
  * Behavior tree system
- * <p/>
+ * <p>
  * Each entity with BehaviorComponent is kept under control by this system. For each such entity a behavior tree
  * is loaded and an interpreter is started.
- * <p/>
+ * <p>
  * Modifications made to a behavior tree will reflect to all entities using this tree.
  */
 @RegisterSystem(RegisterMode.AUTHORITY)

engine/src/main/java/org/terasology/engine/logic/behavior/core/Action.java

@@ -8,7 +8,7 @@
  * The action that is used by an action or decorator node. Every action node of a behavior tree has its own action
  * instance. There is only one action instance for all actors, that run a behavior tree - so all state information
  * needs to be stored at the actor.
- * <p/>
+ * <p>
  * Action instances are shown in the property panel of the behavior editor.
  */
 @API

engine/src/main/java/org/terasology/engine/logic/behavior/core/BehaviorTreeBuilder.java

@@ -40,9 +40,9 @@
 
 /**
  * JSON deserializer to create trees using json:
- * <p/>
+ * <p>
  * { sequence:[action1, {action2:{ foo:bar, duration:7}}] }
- * <p/>
+ * <p>
  * Actions and Decorators need to be registered before parsing.
  */
 public class BehaviorTreeBuilder implements JsonDeserializer<BehaviorNode>, JsonSerializer<BehaviorNode> {

engine/src/main/java/org/terasology/engine/logic/characters/AliveCharacterComponent.java

@@ -6,11 +6,11 @@
 import org.terasology.gestalt.entitysystem.component.EmptyComponent;
 
 /**
- * This is only attached to the <b>alive character</b> entities. <br/>
- * Used to differentiate between alive and dead character entities.<br/><br/>
+ * This is only attached to the <b>alive character</b> entities.<br>
+ * Used to differentiate between alive and dead character entities.<br><br>
  *
  * This needs to be necessarily attached to all character entities that require CharacterMovementComponent
- * for movement systems to work.<br/>
+ * for movement systems to work.<br>
  * Can be used to differently handle situations for character entities that can remain in a dead state
  * or respawn after a while.
  */

engine/src/main/java/org/terasology/engine/logic/characters/CharacterMovementComponent.java

@@ -15,7 +15,7 @@
 
 /**
  * This component is attached to all character entities. It governs movement and stores associated paramenters, and can
- * be used instead of a CapsuleShapeComponent by the physics system to define the collision shape. <br/> The {@link
+ * be used instead of a CapsuleShapeComponent by the physics system to define the collision shape. <br> The {@link
  * AliveCharacterComponent} should necessarily be attached to the character entity for the movement systems to work.
  */
 public final class CharacterMovementComponent implements Component<CharacterMovementComponent> {

engine/src/main/java/org/terasology/engine/logic/players/PlayerCharacterComponent.java

@@ -5,7 +5,7 @@
 import org.terasology.gestalt.entitysystem.component.EmptyComponent;
 
 /**
- * This is only attached to the player entities. <br/>
+ * This is only attached to the player entities. <br>
  * Used to differentiate between player characters and other character entities.
  */
 public class PlayerCharacterComponent extends EmptyComponent<PlayerCharacterComponent> {

engine/src/main/java/org/terasology/engine/logic/players/event/LocalPlayerInitializedEvent.java

@@ -7,7 +7,7 @@
 
 /**
  * This event gets sent when the {@link LocalPlayer} object is ready to be used.
- * <br/>
+ * <br>
  * The object can be injected using {@link org.terasology.engine.registry.In}.
  * This event corresponds with its isValid() method returning true for the first time.
  */

engine/src/main/java/org/terasology/engine/logic/players/event/OnPlayerRespawnedEvent.java

@@ -5,8 +5,8 @@
 import org.terasology.gestalt.entitysystem.event.Event;
 
 /**
- *  This event gets sent when the player respawns.<br/>
- *  The player entity is preserved along with its components during respawn.<br/>
+ *  This event gets sent when the player respawns.<br>
+ *  The player entity is preserved along with its components during respawn.<br>
  *  This event should be received and handled by systems that need to reset
  *  some components attached to the player entity.
  */

engine/src/main/java/org/terasology/engine/math/Side.java

@@ -91,7 +91,7 @@ public static List<Side> horizontalSides() {
 
     /**
      * This provides a static List of all Sides defined in the enumeration. The result contains the same values as
-     * calling {@code Side#values} but this does not create a new copy on every call. <br/>
+     * calling {@code Side#values} but this does not create a new copy on every call.<br>
      *
      * @return All available sides
      */

engine/src/main/java/org/terasology/engine/recording/RecordAndReplayCurrentStatus.java

@@ -5,7 +5,7 @@
 /**
  * Stores the current RecordAndReplayStatus. This class is extremely important since the status is the flag that
  * activates Record and Replay.
- * <p>
+ * <br>
  * <h2>Record Workflow</h2> When the user clicks on the "Record" button on the extras menu, the {@link #status}
  * is set to PREPARING_RECORD. When a game is selected to be loaded from the "Record Screen" and the game is completely
  * loaded, the {@link #status} will be set to RECORDING by the {@link org.terasology.engine.core.modes.loadProcesses.InitialiseRecordAndReplay}
@@ -22,7 +22,7 @@
  * and then every recorded data that was not stored yet will be serialized
  * and stored once {@link org.terasology.engine.persistence.internal.SaveTransaction}'s
  * saveRecordingData() method is called right after the game is saved. Once this is done, the {@link #status} is set to NOT_ACTIVATED.
- * <p>
+ * <br>
  * <h2>Replay Workflow</h2> When the user clicks on the "Replay" button on the extras menu, the {@link #status}
  * is set to PREPEARING_REPLAY. During the load process of a Replay, the {@link org.terasology.engine.core.modes.loadProcesses.InitialiseWorld}
  * class gets the game path from the "recordings" folder instead of the "saves" one,

engine/src/main/java/org/terasology/engine/rendering/world/WorldRendererImpl.java

@@ -61,7 +61,7 @@
  * This implementation works closely with a number of support objects, in particular:
  * <p>
  * TODO: update this section to include new, relevant objects - a RenderableWorld instance, providing acceleration
- * structures caching blocks requiring different rendering treatments<br/>
+ * structures caching blocks requiring different rendering treatments<br>
  */
 public final class WorldRendererImpl implements WorldRenderer {
     /*

engine/src/main/java/org/terasology/engine/utilities/concurrency/TaskMaster.java

@@ -30,7 +30,7 @@
  * <p>
  * When you create a TaskMaster, it is important to shut it down after you're finished with it, generally in the
  * shutdown method of a ComponentSystem. A basic usage example follows:
- * <p>
+ * <br>
  * <pre>
  * {@literal
  * TaskMaster<MyBaseTask> taskMaster = TaskMaster.createFIFOTaskMaster("MyTaskMaster", 1);

engine/src/main/java/org/terasology/engine/world/block/family/AbstractBlockFamily.java

@@ -16,12 +16,7 @@ public abstract class AbstractBlockFamily implements BlockFamily {
     private BlockUri uri;
     private Set<String> categories = Sets.newHashSet();
 
-    protected AbstractBlockFamily(BlockFamilyDefinition definition, BlockShape shape, BlockBuilderHelper blockBuilder) {
-        setBlockUri(new BlockUri(definition.getUrn()));
-        setCategory(definition.getCategories());
-    }
-
-    protected AbstractBlockFamily(BlockFamilyDefinition definition, BlockBuilderHelper blockBuilder) {
+    protected AbstractBlockFamily(BlockFamilyDefinition definition) {
         setBlockUri(new BlockUri(definition.getUrn()));
         setCategory(definition.getCategories());
     }

engine/src/main/java/org/terasology/engine/world/block/family/AttachedToSurfaceFamily.java

@@ -28,13 +28,13 @@ public class AttachedToSurfaceFamily extends AbstractBlockFamily {
     private Map<Side, Block> blocks = Maps.newEnumMap(Side.class);
     private Block archetype;
 
-    public AttachedToSurfaceFamily(BlockFamilyDefinition definition, BlockShape shape, BlockBuilderHelper blockBuilder) {
-        super(definition, shape, blockBuilder);
+    public AttachedToSurfaceFamily(BlockFamilyDefinition definition) {
+        super(definition);
         throw new UnsupportedOperationException("Freeform blocks not supported");
     }
 
     public AttachedToSurfaceFamily(BlockFamilyDefinition definition, BlockBuilderHelper blockBuilder) {
-        super(definition, blockBuilder);
+        super(definition);
 
         Map<Side, Block> blockMap = Maps.newEnumMap(Side.class);
         if (definition.getData().hasSection("top")) {

engine/src/main/java/org/terasology/engine/world/block/family/CeilingSupportingHorizontalFamily.java

@@ -42,7 +42,7 @@ public CeilingSupportingHorizontalFamily(BlockFamilyDefinition definition, Block
     }
 
     public CeilingSupportingHorizontalFamily(BlockFamilyDefinition definition, BlockBuilderHelper blockBuilder) {
-        super(definition, blockBuilder);
+        super(definition);
 
         BlockUri uri = new BlockUri(definition.getUrn());
         populateBlockMaps(blockBuilder, null, definition, uri);

engine/src/main/java/org/terasology/engine/world/block/family/FreeformFamily.java

@@ -30,7 +30,7 @@ public class FreeformFamily extends AbstractBlockFamily implements SideDefinedBl
     private Block archetypeBlock;
 
     public FreeformFamily(BlockFamilyDefinition definition, BlockShape shape, BlockBuilderHelper blockBuilder) {
-        super(definition, shape, blockBuilder);
+        super(definition);
         BlockUri uri;
         if (CUBE_SHAPE_URN.equals(shape.getUrn())) {
             uri = new BlockUri(definition.getUrn());
@@ -54,8 +54,8 @@ public FreeformFamily(BlockFamilyDefinition definition, BlockShape shape, BlockB
         setBlockUri(uri);
     }
 
-    public FreeformFamily(BlockFamilyDefinition blockFamilyDefinition, BlockBuilderHelper blockBuilderHelper) {
-        super(blockFamilyDefinition, blockBuilderHelper);
+    public FreeformFamily(BlockFamilyDefinition blockFamilyDefinition) {
+        super(blockFamilyDefinition);
         throw new UnsupportedOperationException("Shape expected");
     }
 

engine/src/main/java/org/terasology/engine/world/block/family/HorizontalFamily.java

@@ -28,7 +28,7 @@ public class HorizontalFamily extends AbstractBlockFamily implements SideDefined
     private Map<Side, Block> blocks = Maps.newEnumMap(Side.class);
 
     public HorizontalFamily(BlockFamilyDefinition definition, BlockShape shape, BlockBuilderHelper blockBuilder) {
-        super(definition, shape, blockBuilder);
+        super(definition);
         BlockUri uri;
         if (CUBE_SHAPE_URN.equals(shape.getUrn())) {
             uri = new BlockUri(definition.getUrn());
@@ -48,7 +48,7 @@ public HorizontalFamily(BlockFamilyDefinition definition, BlockShape shape, Bloc
     }
 
     public HorizontalFamily(BlockFamilyDefinition definition, BlockBuilderHelper blockBuilder) {
-        super(definition, blockBuilder);
+        super(definition);
         BlockUri uri = new BlockUri(definition.getUrn());
         for (Rotation rot : Rotation.horizontalRotations()) {
             Side side = rot.rotate(Side.FRONT);

engine/src/main/java/org/terasology/engine/world/block/family/MultiConnectFamily.java

@@ -39,25 +39,13 @@ public abstract class MultiConnectFamily extends AbstractBlockFamily implements
 
     protected TByteObjectMap<Block> blocks = new TByteObjectHashMap<>();
 
-    /**
-     * Constructor for a block with a specified shape
-     *
-     * @param definition Family definition
-     * @param shape The shape of the block
-     * @param blockBuilder The builder to make the blocks for the family
-     */
-    public MultiConnectFamily(BlockFamilyDefinition definition, BlockShape shape, BlockBuilderHelper blockBuilder) {
-        super(definition, shape, blockBuilder);
-    }
-
     /**
      * Constructor for a regular block
      *
      * @param definition Family definition
-     * @param blockBuilder The builder to make the blocks for the family
      */
-    public MultiConnectFamily(BlockFamilyDefinition definition, BlockBuilderHelper blockBuilder) {
-        super(definition, blockBuilder);
+    public MultiConnectFamily(BlockFamilyDefinition definition) {
+        super(definition);
     }
 
     /**

engine/src/main/java/org/terasology/engine/world/block/family/SymmetricFamily.java

@@ -19,7 +19,7 @@ public class SymmetricFamily extends AbstractBlockFamily {
     private Block block;
 
     public SymmetricFamily(BlockFamilyDefinition definition, BlockShape shape, BlockBuilderHelper blockBuilder) {
-        super(definition, shape, blockBuilder);
+        super(definition);
         BlockUri uri;
         if (CUBE_SHAPE_URN.equals(shape.getUrn())) {
             uri = new BlockUri(definition.getUrn());
@@ -33,7 +33,7 @@ public SymmetricFamily(BlockFamilyDefinition definition, BlockShape shape, Block
     }
 
     public SymmetricFamily(BlockFamilyDefinition definition, BlockBuilderHelper blockBuilder) {
-        super(definition, blockBuilder);
+        super(definition);
         block = blockBuilder.constructSimpleBlock(definition, new BlockUri(definition.getUrn()), this);
     }
 

engine/src/main/java/org/terasology/engine/world/chunks/localChunkProvider/LocalChunkProvider.java

@@ -62,7 +62,7 @@
  * Provides chunks. Chunks placed in this JVM. Also generated Chunks if needed.
  * <p>
  * Loading/Unload chunks dependent on {@link RelevanceSystem}
- * <p/>
+ * <p>
  * Produces events:
  * <p>
  * {@link OnChunkGenerated} when chunk was generated {@link WorldGenerator}

engine/src/main/java/org/terasology/engine/world/chunks/remoteChunkProvider/RemoteChunkProvider.java

@@ -41,7 +41,7 @@
  * Provides chunks received from remote source.
  * <p>
  * Loading/Unload chunks dependent on {@link org.terasology.engine.network.Server}
- * <p/>
+ * <p>
  * Produce events:
  * <p>
  * {@link OnChunkLoaded} when chunk received from server and processed.