MCR-3285 pmd: UnsynchronizedStaticFormatter #2344
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mewel
force-pushed
the
issues/MCR-3285-pmd-UnsynchronizedStaticFormatter
branch
from
fd68723 to
a78ab70
Compare
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- ruleset.xml: Language not supported
Comments suppressed due to low confidence (1)
mycore-indexing/src/main/java/org/mycore/frontend/indexbrowser/MCRGoogleSitemapCommon.java:213
- [nitpick] The method parameter 'number' should be renamed to 'numberPart' for consistency with the renamed variable 'NUMBER_FORMAT'.
String getFileName(int number, boolean withPath) {
yagee-de
requested changes
Jan 6, 2025
|
|
||
| /** date formatter */ | ||
| private static SimpleDateFormat formatter = new SimpleDateFormat("yyyy-MM-dd", SITEMAP_LOCALE); | ||
| private static final SimpleDateFormat DATE_FORMATTER = new SimpleDateFormat("yyyy-MM-dd", SITEMAP_LOCALE); |
There was a problem hiding this comment.
Should be replaced with https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/time/format/DateTimeFormatter.html which is thread safe
| @@ -106,7 +106,7 @@ private enum Mode { | |||
|
|
|||
| private static Logger LOGGER = LogManager.getLogger(MCRRestAPIObjectsHelper.class); | |||
|
|
|||
| private static SimpleDateFormat SDF_UTC = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US); | |||
| private static final SimpleDateFormat SDF_UTC = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US); | |||
There was a problem hiding this comment.
Should be replaced with https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/time/format/DateTimeFormatter.html which is thread safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.