Use acceleration spike to switch to `LandedState` #118

harshil21 · 2025-01-01T06:13:41Z

Closes #114.

To be merged after #117.

All launch data showed a spike of vertical acceleration of well over 100m/s^2 upon impact. I chose a safe value of 70 and above.

airbrakes/data_handling/data_processor.py

tests/test_integration.py

Also change the value to 50m/s^2

harshil21 added 2 commits January 1, 2025 08:27

Change to LandedState based on accel spike

3fbe323

Adjust integration test

72c4da2

harshil21 added the bug Something isn't working label Jan 1, 2025

harshil21 requested review from JacksonElia and wlsanderson January 1, 2025 06:13

Fix tests

fec4f51

harshil21 mentioned this pull request Jan 1, 2025

Fix LandedState timestamps for genesis launch 1 #119

Merged

wlsanderson mentioned this pull request Jan 7, 2025

DISCUSSION: Defining a more systematic approach for using @property #125

Open

wlsanderson reviewed Jan 7, 2025

View reviewed changes

airbrakes/data_handling/data_processor.py Show resolved Hide resolved

tests/test_integration.py Outdated Show resolved Hide resolved

Base automatically changed from use-py313 to main January 8, 2025 22:37

harshil21 added 3 commits January 8, 2025 17:55

Review WIP: Integration test for accel spike

5a23353

Merge main and fix conflicts

f4d41c0

Add accel spike to integration test

2f80620

Also change the value to 50m/s^2

wlsanderson approved these changes Jan 8, 2025

View reviewed changes

wlsanderson merged commit 5af32dd into main Jan 8, 2025
4 checks passed

wlsanderson deleted the accel-landed-state branch January 8, 2025 23:16

Provide feedback