Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display disappearance, add new field, fix ctrl-c #93

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fix display disappearance, add new field, fix ctrl-c #93

merged 2 commits into from
Nov 21, 2024

Conversation

harshil21
Copy link
Member

Cleanup after #89

@harshil21 harshil21 added the bug Something isn't working label Nov 18, 2024
JacksonElia
JacksonElia requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits

airbrakes/hardware/imu.py Outdated Show resolved Hide resolved
airbrakes/hardware/imu.py Outdated Show resolved Hide resolved
airbrakes/mock/display.py Show resolved Hide resolved
airbrakes/mock/display.py Outdated Show resolved Hide resolved
airbrakes/mock/display.py Outdated Show resolved Hide resolved
@harshil21
Copy link
Member Author

Not going to write tests for the display even though it's desperately needed, because #54 is underway

@JacksonElia JacksonElia merged commit dc90ac1 into main Nov 21, 2024
3 checks passed
@JacksonElia JacksonElia deleted the pred-apg-at-conv branch November 21, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacksonElia JacksonElia JacksonElia approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil21 @JacksonElia