Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added example of github pushing to s3, using oidc #295

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

added example of github pushing to s3, using oidc #295

wants to merge 5 commits into from

Conversation

dlavender4
Copy link
Contributor

No description provided.

@dlavender4 dlavender4 requested a review from a team as a code owner April 18, 2023 09:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dlavender4 dlavender4 requested a review from walteck April 18, 2023 09:56
andyblundell
andyblundell requested changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@andyblundell andyblundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good - needs referencing from somewhere though, not sure there's anywhere suitable yet, maybe we need a new list of handy guides for specific stuff like this?

practices/guides/github-deploy-to-s3.md
11Error: Process completed with exit code 1.

Ensure Role: fails when has wrong GitHub Repo name:
- AWS: edit "GitHubS3DeployRole" Trust Policy. Change GitHub Repo in "token.actions.githubusercontent.com:sub" to something random: "repo:NHSDigitalWRONG/tech-radar:ref:refs/heads/main"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)

practices/guides/github-deploy-to-s3.md
- But took 2min, seemed to be timing out / retrying

Ensure Role fails when has wrong GitHub Branch name:
- AWS: edit "GitHubS3DeployRole" Trust Policy. Change GitHub branch in "token.actions.githubusercontent.com:sub" to something random: "repo:NHSDigital/tech-radar:ref:refs/heads/mainWRONG"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change to RandomOrg/RandomRepo or similar? (To remove reference to radar repo)

amaanibn-nasar1-nhs
amaanibn-nasar1-nhs reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@amaanibn-nasar1-nhs amaanibn-nasar1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting that I've done some work to create a reusable terraform module that does this. https://github.com/NHSDigital/ee-terraform-modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaanibn-nasar1-nhs amaanibn-nasar1-nhs amaanibn-nasar1-nhs left review comments

@andyblundell andyblundell andyblundell requested changes

@walteck walteck Awaiting requested review from walteck

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlavender4 @andyblundell @amaanibn-nasar1-nhs