Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EM-933 Throttling errors withing send-message state machine #159

Draft
wants to merge 73 commits into
base: develop
Choose a base branch
from
Draft

EM-933 Throttling errors withing send-message state machine #159

wants to merge 73 commits into from

Conversation

johnmarston-nhs
Copy link
Contributor

No description provided.

@johnmarston-nhs
EM-933 - dep updates
151abdf
@johnmarston-nhs
EM-933: resolved warning about multiple event endpoints ebing set.
a745c0d
@johnmarston-nhs
EM-933. Added a lock table, locking mechanism and a test for a simple…
da87b5b 
… happy path. Need to add edge cases.
@johnmarston-nhs
EM-933. Added failure to lock and associated test.
39d0aa0
@johnmarston-nhs
EM-933. Implemented lock release and tests.
deb3ffb
@johnmarston-nhs
EM-933. Fixed linter issues.
3ae251a
@johnmarston-nhs
EM-933. TFSec pacification.
c2a5d6d
@johnmarston-nhs
EM-933. TFLint pacification.
8342d4d
@johnmarston-nhs
EM-933. Fixing existing tests to work with the new lock table and fie…
ff7491d 
…lds.
@johnmarston-nhs
EM-933. Fixing existing tests to work with the new lock table and fie…
4f69672 
…lds.
@johnmarston-nhs
EM-933: version bumps.
8c92024
@johnmarston-nhs
EM-933: version bumps.
a07b466
@johnmarston-nhs
EM-933. Remove obsolete tests around invocation directly fro EventBri…
cad5a86 
…dge.
@johnmarston-nhs
EM-933. Merged in changes from other dev branch
0a8e7b5
@johnmarston-nhs
EM-933: ruff fix
09d13dc
@johnmarston-nhs
EM-933. Proper release handling and mocked tests.
3936ccb
@johnmarston-nhs
EM-933. Fixed some import ordering.
849f5df
@johnmarston-nhs
EM-933. Comment rewording.
9ba6520
@johnmarston-nhs
EM-933. Build fixes.
ace6aee
@johnmarston-nhs
EM-933. handling missing lock details when releasing... + tests
97b8c45
@johnmarston-nhs
EM-933. Linting.
c68e057
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
732 616 84% 65% 🟢

New Files

File Coverage Status
src/mesh_lock_manager_application.py 90% 🟢
TOTAL 90% 🟢

Modified Files

File Coverage Status
src/mesh_check_send_parameters_application.py 86% 🟢
src/mesh_fetch_message_chunk_application.py 88% 🟢
src/mesh_poll_mailbox_application.py 74% 🟢
src/mesh_send_message_chunk_application.py 90% 🟢
src/shared/application.py 76% 🟢
src/shared/common.py 75% 🟢
src/shared/config.py 100% 🟢
src/shared/send_parameters.py 99% 🟢
TOTAL 86% 🟢

updated for commit: a24c05d by action🐍

johnmarston-nhs and others added 29 commits October 21, 2024 15:38
@johnmarston-nhs
EM-933. Change the fetch fuction to use the new common locking methods.
8b57c76
@johnmarston-nhs
EM-933. Fix ruff issues.
50fa4e8
@johnmarston-nhs
EM-933. Log level changes.
2a0e62e
@johnmarston-nhs
EM-933. Added expected warnings to the log assertions.
7ad35c9
@johnmarston-nhs
EM-933. Accept more WARN logs.
2227bdf
@james-bradley-nhs
em-933: fix failing tests in send_message_test.py
94683eb
@james-bradley-nhs
em-933: update hooks
c605132
@james-bradley-nhs
em-933: add internal ID to _get_lock_details_from_log_capture
afdd33e
@johnmarston-nhs
EM-933: Fix mocked tests.
8dffeea
@james-bradley-nhs
em-933: find MESHLOCK logs from expected log name
93bb698
@johnmarston-nhs
EM-933: Mypy pacification.
4ad0f17
@johnmarston-nhs
EM-933: extended coverage.
d31f1e8
@james-bradley-nhs
em-933: add lock manger lambda
4c40cd1
@james-bradley-nhs
em-933: assert lock does not remain in dynamoDB
4ee319d
@james-bradley-nhs
em-933: add unit tests
bb0be32
@james-bradley-nhs
em-933: add dynamo to IAM policy document
db28c8d
@james-bradley-nhs
em-933: send messages uses lock manager lambda to release lock
c8fa23e
@james-bradley-nhs
em-933: remove MESHLOCK0007 assertion from pagination test
50b673c
@james-bradley-nhs
em-933: remove MESHLOCK0007 from get handshake test
a9596f0
@james-bradley-nhs
em-933: fix lock manager unit test
96fa0d2
@james-bradley-nhs
em-933: add dynamo db access to check send paramaters
88ec875
@james-bradley-nhs
em-933: give check_send_parameters UpdateItem permission
b6eae24
@james-bradley-nhs
em-933: fix resource name for dynamo permissions
007da3d
@james-bradley-nhs
em-933: remove / in resource name for dynamo permissions
86dbbe8
@james-bradley-nhs
em-933: give send_message_chunk dynamodb:updateItem permission
876eb79
@james-bradley-nhs
em-933: give step function lambda:InvokeFunction permission for the l…
b2aae93 
…ock manager
@james-bradley-nhs
em-933: add iam policies for fectching messages
f8c79b7
@james-bradley-nhs
em-933: update tflint.hcl
1264e40
@james-bradley-nhs
em-933: clear up print statements in lock manager
a24c05d
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-mercer matt-mercer Awaiting requested review from matt-mercer matt-mercer will be requested when the pull request is marked ready for review matt-mercer is a code owner

@ranisen ranisen Awaiting requested review from ranisen ranisen will be requested when the pull request is marked ready for review ranisen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnmarston-nhs @james-bradley-nhs