-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* Refactored Document and TimingMetadata to not extend Attribute #1927
base: integration
Are you sure you want to change the base?
Conversation
ivakegg
commented
Apr 11, 2023
- Simplified any logic looking for nested documents
d7f8989
to
291895e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice cleanup.
warehouse/query-core/src/main/java/datawave/query/attributes/Attribute.java
Outdated
Show resolved
Hide resolved
d43de09
to
fcfa3fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of rushed through this at the end once i got to the tests, but I had a few comments.
warehouse/query-core/src/main/java/datawave/query/iterator/QueryOptions.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/QueryOptions.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/predicate/EmptyDocumentFilter.java
Show resolved
Hide resolved
8cdc7b8
to
a781aac
Compare
e83d48d
to
f86e38d
Compare
* Simplified any logic looking for nested documents * Ensure everything is actually serializable * Made the projection testing a little more robust * Updated to avoid creating a copy of the document
baf4e1b
to
e46c7a1
Compare
In DocumentProjection, the following constructor arguments and class memebers are no longer used. Is this intentional?
|
@billoley Cleaned up those members and constructors. Thanks! |