Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WritesQueryMetrics to EventQueryTransformer #2661

Open
wants to merge 5 commits into
base: integration
Choose a base branch
from

Conversation

SethSmucker
Copy link
Collaborator

Update EventQueryTransformerSupport to implement WritesQueryMetrics so EventQueryTransformer has access to the methods.

Follows the structure of DocumentTransformerSupport implementing WritesQueryMetrics instead of implementing it directly into DocumentTransformer.

fixes #2605

@billoley
Copy link
Collaborator

billoley commented Dec 23, 2024

I think the reason that EventQueryTransformer does not implement WritesQueryMetrics is that the logics using this transformer do not use the QueryIterator, do not track or return these metrics, and do not have a Document to call extractMetrics.

Recommend closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventQueryTransformer does not implement WritesQueryMetrics
2 participants