-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update plugins for maven 3.6.3+ #1011
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not done checking yet.
Ran the following goals so far (compile, verify, site)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build these changes internally using this 'incremental' path of commands:
mvn clean verify
mvn clean install
mvn clean verify -Pcheckstyle
mvn clean verify -Pcheckstyle,pmd,coverage
mvn clean site
mvn clean deploy (failed to connect to repo due to access but plugin worked)
mvn clean install site -Pcheckstyle,pmd,coverage
All of which 'worked' (success at the end) but I believe I could have just done the last command and been covered (except for deploy), it just would have been harder to find issues with missing dependencies.
I did run into an issue where the maven-project-info-reports had errors when using the cyclonedx plugin. I recommend bumping that to the latest 2.9.1 version as well as adding this plugin dependency (in the dist profile config) to try to manage the version being used with cyclone (it uses 2.0.8 now):
<plugin>
<groupId>io.takari.maven.plugins</groupId>
<artifactId>takari-lifecycle-plugin</artifactId>
<version>2.2.0</version>
</plugin>
I also see an error during pmd generating the CPD report for a NoSuchMethodError which complains about org.apache.maven.doxia.sink.Sink.verbatim(). I didn't investigate if that was new or where that might have started but it appears as though there are two versions of doxia being included, 2.0.0 and 1.11.1 using:
mvn dependency:resolve-plugins
Since the result is not a failure of the build but a failure of report generation I'm ok moving forward and resolving in a follow-up pending your feedback.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me!
No description provided.