bug :: preserve original behavior for getStringParameter #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ull not an empty string
dev-mlb
force-pushed
the
ibdo-str-param-fix
branch
from
712f705 to
2f072d9
Compare
…ull not an empty string
…ull not an empty string
dev-mlb
changed the title
dev-mlb
force-pushed
the
ibdo-str-param-fix
branch
from
1ee166f to
1a11901
Compare
jpdahlke
previously approved these changes
Dec 30, 2024
There was a problem hiding this comment.
The two situations we were running into:
- getStringParameter was no longer returning "" when the value was "" (nor was the new method getParameterAsConcatString)
- the new getParameterAsString method was returning null for single entry parameters with a value of "".
This looks to solve both of those and add tests to show it.
|
This will be included in a patch release of 8.19.1 |
fbruton
requested changes
Dec 30, 2024
jpdahlke
approved these changes
Dec 30, 2024
fbruton
approved these changes
Dec 30, 2024
rpg36
pushed a commit
to rpg36/emissary
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.