Allow async functions to throw #178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a convenient means to allow asynchronous functions to throw an exception rather than return a value.
clvs7-gh
reviewed
Feb 29, 2020
Existing usage includes calling the callback with no arguments, intending it to return undefined. Preserve this behaviour by treating zero and one arguments equivalently, and only throwing if it is called with two or more. (This will break any existing usage which calls the callback with more than one argument, but that ought to be fairly uncommon!)
This was referenced Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a convenient means to allow asynchronous functions to throw an exception rather than return a value.