Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#446 #447

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix issue#446 #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9e65ba
fix issue#446
May 22, 2023
e42a334
update
May 25, 2023
f6ebd97
remain compileOnly
May 26, 2023
f12c3de
update spectator dependency
May 27, 2023
a32e0cc
update runtime build.gradle
May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions mantis-common/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,12 @@ dependencies {
api "org.xerial.snappy:snappy-java:$snappyVersion"
api "org.jctools:jctools-core:$jctoolsVersion"

// spectatorApi should be packaged at entry point level to avoid version conflicts.
compileOnly libraries.spectatorApi

api libraries.mantisShaded
api libraries.rxNettyShaded
api libraries.rxJava
api libraries.slf4jApi
api libraries.slf4jLog4j12
implementation libraries.spectatorApi
implementation libraries.commonsIo
implementation 'net.jcip:jcip-annotations:1.0'

Expand Down
2 changes: 1 addition & 1 deletion mantis-runtime/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies {
api project(':mantis-common')
api libraries.slf4jApi
compileOnly libraries.jsr305
compileOnly libraries.spectatorApi
implementation libraries.spectatorApi
testImplementation libraries.spectatorApi
testImplementation libraries.junit4
testImplementation libraries.mockitoCore
Expand Down