Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for review] Make TOGGLE_DECOSPECS only add default decorator once. #2097

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

darinyu
Copy link
Collaborator

@darinyu darinyu commented Oct 13, 2024

This is needed when we add value to DECOSPECS (or TOGGLE_DECOPSECS).

Changes:

  1. update the METAFLOW_DECOSPECS (from config) to METAFLOW_DEFAULT_DECOSPECS. This will no longer collide with user override METAFLOW_DECOSPECS which translate to --with
  2. move config_merge_cb from start to common_options. Reasoning:

Before the change:
when we use TOGGLE_DECOSPECS and run a flow, it first inject X as decorator at flow level (by this config_merge_cb. It then get passed to the subprocess when we run step. When step starts, it injects this X again.

After the change
when we use TOGGLE_DECOSPECS and run a flow, it no longer inject X (because this config_merge_cb is no longer in start in cli.py), When subprocess starts to run step, we inject this X to decorator (via common_options).

@darinyu darinyu changed the title do not let default decospec overwrite existing "--with" [WIP] do not let default decospec overwrite existing "--with" Oct 13, 2024
@darinyu darinyu changed the title [WIP] do not let default decospec overwrite existing "--with" [Ready for review] Make TOGGLE_DECOSPECS only add default decorator once. Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant