[Ready for review] Make TOGGLE_DECOSPECS only add default decorator once. #2097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when we add value to DECOSPECS (or TOGGLE_DECOPSECS).
Changes:
--with
config_merge_cb
fromstart
tocommon_options
. Reasoning:Before the change:
when we use TOGGLE_DECOSPECS and run a flow, it first inject
X
as decorator at flow level (by thisconfig_merge_cb
. It then get passed to the subprocess when we runstep
. Whenstep
starts, it injects thisX
again.After the change
when we use TOGGLE_DECOSPECS and run a flow, it no longer inject
X
(because thisconfig_merge_cb
is no longer instart
incli.py
), When subprocess starts to runstep
, we inject thisX
to decorator (viacommon_options
).