Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SnapSync=true to EnergyWeb and Volta #8000

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kamilchodola
Copy link
Contributor

@kamilchodola kamilchodola commented Jan 3, 2025

Adding SnapSync = true to Energyweb as bootnodes are in process of resyncing to HalfPath with SnapServer
Same for Volta.

To be merged only when we will have final confirmation from EnergyWeb team that migration is completed and we will prove that everything works smoothly.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

Snap Sync enabled in EnergyWeb chains (EnergyWeb and Volta). This will drastically reduce the sync time of those chains (from 10h+ to minutes of sync).

@kamilchodola kamilchodola requested review from rubo and a team as code owners January 3, 2025 16:02
@benaadams
Copy link
Member

Fails check expecting it to be false

  Failed Snap_sync_settings_as_expected("energyweb.json",False) [114 ms]
  Error Message:
   Expected object to be False because energyweb.json: ISyncConfig.SnapSync, but found True.

@kamilchodola kamilchodola changed the title Add SnapSync true to energyweb Add SnapSync=true to EnergyWeb and Volta Jan 3, 2025
@kamilchodola
Copy link
Contributor Author

@benaadams this test doesn't makes sense imo :D

@benaadams
Copy link
Member

@benaadams this test doesn't makes sense imo :D

Just need to change it to expect true?

@kamilchodola
Copy link
Contributor Author

@benaadams this test doesn't makes sense imo :D

Just need to change it to expect true?

Yes yes - just not sure if this test helps in anything :) Adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants