-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SnapSync=true to EnergyWeb and Volta #8000
Open
kamilchodola
wants to merge
4
commits into
master
Choose a base branch
from
kch/ewb_snap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails check expecting it to be false
|
benaadams
approved these changes
Jan 3, 2025
kamilchodola
changed the title
Add SnapSync true to energyweb
Add SnapSync=true to EnergyWeb and Volta
Jan 3, 2025
@benaadams this test doesn't makes sense imo :D |
Just need to change it to expect true? |
Yes yes - just not sure if this test helps in anything :) Adjusted. |
benaadams
approved these changes
Jan 3, 2025
LukaszRozmej
approved these changes
Jan 4, 2025
MarekM25
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding SnapSync = true to Energyweb as bootnodes are in process of resyncing to HalfPath with SnapServer
Same for Volta.
To be merged only when we will have final confirmation from EnergyWeb team that migration is completed and we will prove that everything works smoothly.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes
Snap Sync enabled in EnergyWeb chains (EnergyWeb and Volta). This will drastically reduce the sync time of those chains (from 10h+ to minutes of sync).