Fix missing tx index on reorg #8027
Open
+33
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jan 8, 2025
Comment on lines
382
to
388
| byte[] txIndexData = _transactionDb.Get(tx.Hash); | ||
| if (txIndexData is not null && txIndexData.Length != Hash256.Size) | ||
| { | ||
| long blockNumber = new RlpStream(txIndexData).DecodeLong(); | ||
| if (blockNumber != block.Number) continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe simpler fix would be never remove block transactions and allow for it pointing to a block where it doesn't exist, and then handle that on searching for receipt?
There was a problem hiding this comment.
Yea, I guess that works too
There was a problem hiding this comment.
You are still removing it though?
There was a problem hiding this comment.
Method also use to remove old tx index (the tx lookup limit config). So its no longer called during reorg.
There was a problem hiding this comment.
Ah you are right, I was confused about method being still there, but it is for pruning.
Can you confirm it doesn't break eth_getLogs and eth_getTransactionReceipt ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6560
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing