Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRUM-109] 타임피커 스크롤 버그 수정 #67

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

devMinseok
Copy link
Member

무엇에 관한 PR 인가요? 🙋

  • Wheelpicker 스크롤 오작동 문제 해결

어떤 것을 작업하셨나요? 🛠

원인:

  • 정확히는 아래 코드가 범인
    .padding(.vertical, itemHeight * itemsCountAbove)
  • Spacer(), padding을 줘서 상하단을 여백을 주면 scrollTargetBehavior가 오작동 함
  • iOS17에서는 괜찮았는데 업데이트 하면서 뭔가 바뀐듯

@devMinseok devMinseok added the bug Something isn't working label Dec 29, 2024
@devMinseok devMinseok self-assigned this Dec 29, 2024
@devMinseok devMinseok requested a review from Jihyun247 December 29, 2024 13:08
@devMinseok devMinseok merged commit 13aaee3 into develop Dec 29, 2024
1 check passed
@devMinseok devMinseok deleted the feature/SCRUM-109 branch December 29, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant