Feature: Timer Service Refactoring #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-ji-hoon
commented
Oct 19, 2024
| import timber.log.Timber | ||
|
|
||
| internal class PomodoroNotificationManager @Inject constructor( | ||
| @PomodoroNotification private val notificationBuilder: NotificationCompat.Builder, |
There was a problem hiding this comment.
어제 밤에 이야기 했던 NotificationBuilder 를 hilt를 아직 유지한 이유는 app과 관련된 정보를 presenter에서 알 수가 없다 보니 우선 유지하고 해당 정보들을 어떻게 할지 좀 고민해볼게
Comment on lines
-42
to
-43
| private var focusTimer: Timer? = null | ||
| private var restTimer: Timer? = null |
There was a problem hiding this comment.
하나의 Service에서 2개의 Timer 로직을 갖고 있으니 구분도 어렵고, 코딩을 할 때 실수가 잦아져서 구성 자체를 변경
HyomK
reviewed
Oct 20, 2024
| android:name=".presentation.service.focus.PomodoroFocusTimerService" | ||
| android:foregroundServiceType="specialUse"> | ||
| <meta-data | ||
| android:name="android.app.PROPERTY_SPECIAL_USE_FGS_SUBTYPE" |
There was a problem hiding this comment.
Android 14 대응이구나
가이드 보니까 meta-data 말고 property 태그를 사용하던데 차이가 있을까?
https://developer.android.com/about/versions/14/changes/fgs-types-required
There was a problem hiding this comment.
meta-data 가 익숙해서 사용한거였는데, 찾아 보니 property 는 Android 14부터 도입된 개념으로 나오네 이 방법으로 해동 상관 없을거 같아 변경해두고 다시 멘션할게!
There was a problem hiding this comment.
| import timber.log.Timber | ||
|
|
||
| internal class PomodoroNotificationManager @Inject constructor( | ||
| @PomodoroNotification private val notificationBuilder: NotificationCompat.Builder, |
HyomK
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
체크리스트
동작 화면
살려주세요
LocalNotificationReceiver나 다른 Service는 다음 PR에 나눠서 올릴 예정작업 내용
체크리스트
동작 화면
살려주세요