Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LoginEvent에서 디바이스를 찾지 못하는 오류 수정 #112

Merged
merged 4 commits into from
Dec 22, 2024

Conversation

kimyu0218
Copy link
Collaborator

@kimyu0218 kimyu0218 commented Dec 22, 2024

Issue Number

close: #

작업 개요

(#108)
LoginEvent에서 디바이스 식별자를 전달하게 되는데, 사전에 디바이스 토큰을 업데이트하지 않은 사용자는 디바이스 레코드가 존재하지 않아 404 오류가 발생한다.

작업 사항

디바이스가 없는 경우에 대해 분기 처리를 진행했습니다.

Device device = deviceRepository.findByMemberIdAndDeviceIdentifier(memberId, deviceIdentifier)
    .orElse(null);
if (device == null) {
    return;
}

고민한 점들(필수 X)

여기에 작성하세요

스크린샷(필수 X)

여기에 작성하세요

@kimyu0218 kimyu0218 requested a review from songyi00 as a code owner December 22, 2024 06:52
@kimyu0218 kimyu0218 merged commit 80d137c into develop Dec 22, 2024
1 check passed
@kimyu0218 kimyu0218 deleted the fix/#108-fcm-push branch December 22, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant