Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data validation module using Pydantic #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add data validation module using Pydantic #128

wants to merge 1 commit into from

Conversation

devarshpatel1506
Copy link

@devarshpatel1506 devarshpatel1506 commented Nov 25, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@devarshpatel1506 devarshpatel1506 requested a review from a team as a code owner November 25, 2024 22:32
dannymeijer
dannymeijer requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dannymeijer dannymeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you trying to achieve with this PR? You can't rename the entire src module as you have... Please adjust your PR to only what you want to change and add a description.

@dannymeijer
Copy link
Member

Please also see: #129

@dannymeijer dannymeijer mentioned this pull request Nov 27, 2024
Open
9 tasks
@dannymeijer
Copy link
Member

There has not been any response for the last 2 weeks. Please respond or address the aforementioned concerns before the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannymeijer dannymeijer dannymeijer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devarshpatel1506 @dannymeijer