Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [ADD] account_payment_order_inter_company #516

Closed
wants to merge 4 commits into from
Closed

[14.0] [ADD] account_payment_order_inter_company #516

wants to merge 4 commits into from

Conversation

chafique-delli
Copy link
Contributor

No description provided.

@chafique-delli chafique-delli mentioned this pull request Oct 10, 2023
Closed
@chafique-delli
Copy link
Contributor Author

@alexis-via , @sebastienbeau

rvalyi
rvalyi requested changes Oct 10, 2023
View reviewed changes
account_payment_order_inter_company/readme/DESCRIPTION.rst Outdated
@@ -0,0 +1 @@
This module allows to map tax and account depending of the product.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this is not the proper description. Meanwhile, in the module README.rst, the description looks better:
"This module allows for an inter-company billing to automatically pay the invoice in Company A as soon as the invoice in Company B is paid." So I'm not sure why these two descriptions are different, but it looks this one is not correct...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvalyi , You're right, I fixed that.

@chafique-delli chafique-delli force-pushed the 14.0-ADD-account_payment_order_inter_company branch from b7dca3a to ee76ff3 Compare November 23, 2023 09:47
@chafique-delli chafique-delli marked this pull request as draft November 23, 2023 10:00
@chafique-delli chafique-delli force-pushed the 14.0-ADD-account_payment_order_inter_company branch from d47fd0b to e4d89f3 Compare November 24, 2023 18:24
@chafique-delli chafique-delli marked this pull request as ready for review November 24, 2023 18:28
@chafique-delli
Copy link
Contributor Author

@sebastienbeau, @rvalyi

@legalsylvain
Copy link
Contributor

@sebastienbeau, @rvalyi : friendly reminder.

@legalsylvain legalsylvain added this to the 14.0 milestone Dec 17, 2023
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@github-actions github-actions bot closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi requested changes

Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chafique-delli @legalsylvain @rvalyi @sebastienbeau