-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] account_multicompany_easy_creation: Migration to 17.0 #739
Open
victoralmau
wants to merge
16
commits into
OCA:17.0
Choose a base branch
from
Tecnativa:17.0-mig-account_multicompany_easy_creation
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] account_multicompany_easy_creation: Migration to 17.0 #739
victoralmau
wants to merge
16
commits into
OCA:17.0
from
Tecnativa:17.0-mig-account_multicompany_easy_creation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] Update account_multicompany_easy_creation.pot [UPD] README.rst
…eation. account_multicompany_easy_creation 13.0.1.0.1
…te correctly + Tests account_multicompany_easy_creation 13.0.1.0.2
… function to update only records with taxes. account_multicompany_easy_creation 13.0.1.0.3
Matching taxes by description is no longer reliable TT32316 [UPD] Update account_multicompany_easy_creation.pot account_multicompany_easy_creation 13.0.1.0.4
[UPD] Update account_multicompany_easy_creation.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-16.0/multi-company-16.0-account_multicompany_easy_creation Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-account_multicompany_easy_creation/
Currently translated at 100.0% (56 of 56 strings) Translation: multi-company-16.0/multi-company-16.0-account_multicompany_easy_creation Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-account_multicompany_easy_creation/es/ [UPD] README.rst
Translated using Weblate (Italian) Currently translated at 100.0% (56 of 56 strings) Translation: multi-company-16.0/multi-company-16.0-account_multicompany_easy_creation Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-account_multicompany_easy_creation/it/
…/pos_restaurant module is installed. (impossibility to access to pos.payment.method model)
Changes done: - The default_sale_tax_id and default_purchase_tax_id fields that reference account.tax.template are removed because model does not exist and it would not be consistent to be able to set already existing taxes (account.tax). If applicable, the localization (l10n_en for example) addon will define account_sale_tax_id and account_purchase_tax_id values at the res.company level that will be used for the same purpose. - The fields reference to account.account.template are not necessary, when applying the chart template the ir.property records linked to the new company (property_account_receivable_id, property_account_payable_id, property_account_expense_categ_id and property_account_income_categ_id) are already set. TT50048
/ocabot migration account_multicompany_easy_creation |
carlos-lopez-tecnativa
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0
Changes done:
default_sale_tax_id
anddefault_purchase_tax_id
fields that referenceaccount.tax.template
are removed because model does not exist and it would not be consistent to be able to set already existing taxes (account.tax
). If applicable, the localization (l10n_en
for example) addon will defineaccount_sale_tax_id
andaccount_purchase_tax_id
values at theres.company
level that will be used for the same purpose.account.account.template
are not necessary, when applying the chart template their.property
records linked to the new company (property_account_receivable_id
,property_account_payable_id
,property_account_expense_categ_id
andproperty_account_income_categ_id
) are already set.@Tecnativa TT50048