Fall back to <html> if #js-repo-pjax-container is missing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows this module to be used with [Turbolinks] sites like GitLab. For a demo: * Visit https://gitlab.com/gitlab-org/gitlab-ce * Paste the contents of this file into the console * Paste the following into the console: ```javascript gitHubInjection(window, function(err) { if (err) { return console.error(err); } console.warn("XXX INJECTION"); }); ``` * Click the "Activity" link * Notice "XXX INJECTION" printed to the console [Turbolinks]: https://github.com/turbolinks/turbolinks See OctoLinker/OctoLinker#113
|
Looks good to me, but can you add a test please? The tests are running two times. Once against a fixture file and a second time against the real website. Check out the (test helper]( Line 19 in ed77e40 Finally, can you add another fallback for bitbucket with Thank you. |
|
Btw the tests are failing because of coveralls.io which has an outdated configuration. I'm on it |
|
Changes Unknown when pulling 9c8e2e0 on josephfrazier:gitlab into * on OctoLinker:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows this module to be used with Turbolinks sites like GitLab.
For a demo:
See OctoLinker/OctoLinker#113