Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache RootResource per endpoint rather than per repository #870

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Cache RootResource per endpoint rather than per repository #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...Tests/PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETCore.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusAsyncRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Task<IOctopusAsyncClient> AsUser(String, Octopus.Client.OctopusClientOptions)
Task<TResource> Create(String, Octopus.Client.TResource, Object)
Task<TResource> Create(String, Octopus.Client.TResource, CancellationToken)
Task<TResource> Create(String, Octopus.Client.TResource, Object, CancellationToken)
Expand Down Expand Up @@ -98,6 +99,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Octopus.Client.IOctopusClient AsUser(String, Octopus.Client.OctopusClientOptions)
Octopus.Client.TResource Create(String, Octopus.Client.TResource, Object)
Octopus.Client.TResponse Create(String, Octopus.Client.TCommand, Object)
void Delete(String, Object, Object)
Expand Down Expand Up @@ -169,6 +171,10 @@ Octopus.Client
Octopus.Client.IOctopusSystemRepository
{
}
interface IOctopusServerRootResourceCache
{
Octopus.Client.Model.RootResource CachedRootResource { get; set; }
}
interface IOctopusSpaceAsyncRepository
Octopus.Client.IOctopusCommonAsyncRepository
{
Expand Down Expand Up @@ -303,6 +309,7 @@ Octopus.Client
class OctopusAsyncClient
Octopus.Client.IOctopusAsyncClient
IDisposable
Octopus.Client.IOctopusServerRootResourceCache
{
event Action<HttpResponseMessage> AfterReceivedHttpResponse
event Action<HttpRequestMessage> BeforeSendingHttpRequest
Expand All @@ -311,6 +318,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusAsyncRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Task<IOctopusAsyncClient> AsUser(String, Octopus.Client.OctopusClientOptions)
static Task<IOctopusAsyncClient> Create(Octopus.Client.OctopusServerEndpoint, Octopus.Client.OctopusClientOptions)
Task<TResource> Create(String, Octopus.Client.TResource, Object)
Task<TResource> Create(String, Octopus.Client.TResource, CancellationToken)
Expand Down Expand Up @@ -451,6 +459,7 @@ Octopus.Client
Octopus.Client.IHttpOctopusClient
Octopus.Client.IOctopusClient
IDisposable
Octopus.Client.IOctopusServerRootResourceCache
{
event Action<WebResponse> AfterReceivingHttpResponse
event Action<WebRequest> BeforeSendingHttpRequest
Expand All @@ -460,6 +469,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Octopus.Client.IOctopusClient AsUser(String, Octopus.Client.OctopusClientOptions)
Octopus.Client.TResource Create(String, Octopus.Client.TResource, Object)
Octopus.Client.TResponse Create(String, Octopus.Client.TCommand, Object)
void Delete(String, Object, Object)
Expand Down Expand Up @@ -618,13 +628,15 @@ Octopus.Client
Octopus.Client.TResponseResource ResponseResource { get; }
}
class OctopusServerEndpoint
Octopus.Client.IOctopusServerRootResourceCache
{
.ctor(String)
.ctor(String, String)
.ctor(String, String, ICredentials)
.ctor(Octopus.Client.ILinkResolver, String, ICredentials)
String ApiKey { get; }
String BearerToken { get; }
Octopus.Client.Model.RootResource CachedRootResource { get; set; }
ICredentials Credentials { get; }
Boolean IsUsingSecureConnection { get; }
Octopus.Client.ILinkResolver OctopusServer { get; }
Expand Down
12 changes: 12 additions & 0 deletions .../PublicSurfaceAreaFixture.ThePublicSurfaceAreaShouldNotRegress..NETFramework.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusAsyncRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Task<IOctopusAsyncClient> AsUser(String, Octopus.Client.OctopusClientOptions)
Task<TResource> Create(String, Octopus.Client.TResource, Object)
Task<TResource> Create(String, Octopus.Client.TResource, CancellationToken)
Task<TResource> Create(String, Octopus.Client.TResource, Object, CancellationToken)
Expand Down Expand Up @@ -98,6 +99,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Octopus.Client.IOctopusClient AsUser(String, Octopus.Client.OctopusClientOptions)
Octopus.Client.TResource Create(String, Octopus.Client.TResource, Object)
Octopus.Client.TResponse Create(String, Octopus.Client.TCommand, Object)
void Delete(String, Object, Object)
Expand Down Expand Up @@ -169,6 +171,10 @@ Octopus.Client
Octopus.Client.IOctopusSystemRepository
{
}
interface IOctopusServerRootResourceCache
{
Octopus.Client.Model.RootResource CachedRootResource { get; set; }
}
interface IOctopusSpaceAsyncRepository
Octopus.Client.IOctopusCommonAsyncRepository
{
Expand Down Expand Up @@ -303,6 +309,7 @@ Octopus.Client
class OctopusAsyncClient
Octopus.Client.IOctopusAsyncClient
IDisposable
Octopus.Client.IOctopusServerRootResourceCache
{
event Action<HttpResponseMessage> AfterReceivedHttpResponse
event Action<HttpRequestMessage> BeforeSendingHttpRequest
Expand All @@ -311,6 +318,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusAsyncRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Task<IOctopusAsyncClient> AsUser(String, Octopus.Client.OctopusClientOptions)
static Task<IOctopusAsyncClient> Create(Octopus.Client.OctopusServerEndpoint, Octopus.Client.OctopusClientOptions)
Task<TResource> Create(String, Octopus.Client.TResource, Object)
Task<TResource> Create(String, Octopus.Client.TResource, CancellationToken)
Expand Down Expand Up @@ -451,6 +459,7 @@ Octopus.Client
Octopus.Client.IHttpOctopusClient
Octopus.Client.IOctopusClient
IDisposable
Octopus.Client.IOctopusServerRootResourceCache
{
event Action<WebResponse> AfterReceivingHttpResponse
event Action<WebRequest> BeforeSendingHttpRequest
Expand All @@ -460,6 +469,7 @@ Octopus.Client
Boolean IsUsingSecureConnection { get; }
Octopus.Client.IOctopusRepository Repository { get; }
Octopus.Client.Model.RootResource RootDocument { get; }
Octopus.Client.IOctopusClient AsUser(String, Octopus.Client.OctopusClientOptions)
Octopus.Client.TResource Create(String, Octopus.Client.TResource, Object)
Octopus.Client.TResponse Create(String, Octopus.Client.TCommand, Object)
void Delete(String, Object, Object)
Expand Down Expand Up @@ -616,13 +626,15 @@ Octopus.Client
Octopus.Client.TResponseResource ResponseResource { get; }
}
class OctopusServerEndpoint
Octopus.Client.IOctopusServerRootResourceCache
{
.ctor(String)
.ctor(String, String)
.ctor(String, String, ICredentials)
.ctor(Octopus.Client.ILinkResolver, String, ICredentials)
String ApiKey { get; }
String BearerToken { get; }
Octopus.Client.Model.RootResource CachedRootResource { get; set; }
ICredentials Credentials { get; }
Boolean IsUsingSecureConnection { get; }
Octopus.Client.ILinkResolver OctopusServer { get; }
Expand Down
Loading
Loading