Skip to content

Commit

Permalink
Remove logging since this code path is essentially untestable.
Browse files Browse the repository at this point in the history
Reverts part of the original fix from #60 (we can't get this path covered with reasonable effort).
  • Loading branch information
tintoy committed Jan 11, 2018
1 parent 39167aa commit 86226b7
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/Server/LspRequestRouter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,9 @@ public async Task<ErrorResponse> RouteRequest(IHandlerDescriptor descriptor, Req
{
@params = request.Params?.ToObject(descriptor.Params, _serializer.JsonSerializer);
}
catch (Exception cannotDeserializeRequestParams)
catch
{
_logger.LogError(new EventId(-32602), cannotDeserializeRequestParams, "Failed to deserialise request parameters.");

return new InvalidParams(request.Id);
return new InvalidParams(request.Id);
}

result = ReflectionRequestHandlers.HandleRequest(descriptor, @params, cts.Token);
Expand Down

0 comments on commit 86226b7

Please sign in to comment.